Review main Merged

81415[TASK] Partially revert method signature change for FileInterface->rename

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 10/12/23, 09:09

Commit message

This is a pre-patch for introducing a native enum for
DuplicationBehavior. In order to prevent changes to the signature of
`$conflictMode` two times, we omit the typehint `string` in v13 and will
change it in v14 immediately to native enum `DuplicationBehavior`.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Thomas Hohn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 67

  1. Nikita Hovratov uploaded patch set 1 10/12/23, 08:11

  2. Thomas Hohn voted on patch set 1 CR +1 10/12/23, 08:13

  3. core-ci voted on patch set 1 V +1 10/12/23, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47703

  4. Oliver Klee voted on patch set 1 V +1 CR +1 10/12/23, 08:32

  5. Thomas Hohn voted on patch set 1 V +1 10/12/23, 09:05

  6. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/12/23, 09:09

  7. Nikita Hovratov merged patch set 2 10/12/23, 09:09