Review main Merged

81416[TASK] Use descriptions over placeholders in sys_file_storage

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 10/12/23, 11:08

Commit message

It is best practice to use permanently visible information to help to
fill out forms of any kind. In case of sys_file_storage the placeholder
is even partially cut off, so one can't read the whole text.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Nikita Hovratov uploaded patch set 1 10/12/23, 10:36

  2. core-ci voted on patch set 1 V +1 10/12/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47710

  3. Oliver Klee voted on patch set 1 CR +1 10/12/23, 10:48

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/12/23, 10:58

  5. Oliver Klee voted on patch set 1 V +1 10/12/23, 11:03

  6. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/12/23, 11:08

  7. Nikita Hovratov merged patch set 2 10/12/23, 11:08