Review main Merged

81417[FEATURE] Add webp support for GifBuilder

Benni Mack CR +2 V +2 Normal +140 −37 updated 10/30/23, 21:59

Commit message

It is now possible - if PHP was compiled with gdlib
that supports webp (available since PHP 7.1), to generate
webp files via GifBuilder.

Example:

page.10 = IMAGE
page.10 {
  file = GIFBUILDER
  file {
    backColor = yellow
    XY = 1024,199
    format = webp
    quality = 44

    10 = IMAGE
    10.offset = 10,10
    10.file = 1:/backimage.jpg
  }
}

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1925

  1. Benni Mack uploaded patch set 1 10/12/23, 11:03

  2. core-ci voted on patch set 1 V +1 10/12/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47711

  3. Benni Mack updated the commit message in patch set 2 V +1 10/16/23, 11:02

  4. Benni Mack uploaded patch set 3 10/16/23, 11:05

  5. core-ci voted on patch set 3 V +1 10/16/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47819

  6. core-ci voted on patch set 2 V +1 10/16/23, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47818

  7. Benni Mack uploaded patch set 4 V +1 10/16/23, 19:19

  8. core-ci voted on patch set 4 V +1 10/16/23, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47839

  9. Andreas Nedbal voted on patch set 4 V +1 CR +1 10/16/23, 23:30

  10. Oliver Hader commented on patch set 4 10/17/23, 06:00

    GifBuilderTest.php:201

    What about using a data-provider here for `webp`, `png`, ...?
  11. Benni Mack uploaded patch set 5 CR +1 V +1 10/17/23, 07:06

  12. Benni Mack commented on patch set 5 10/17/23, 07:07

    GifBuilderTest.php:201 Reply

    Done

    GifBuilderTest.php:204 Reply

    Done
  13. core-ci voted on patch set 5 V +1 10/17/23, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47844

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 10/17/23, 07:28

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 10/17/23, 07:38

  16. Simon Schaufelberger updated the commit message in patch set 6 CR +1 V +1 10/17/23, 08:21

  17. Christian Kuhn rebased onto patch set 7 10/17/23, 09:35

  18. core-ci voted on patch set 7 V +1 10/17/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47854

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 10/17/23, 09:49

  20. Andreas Kienast voted on patch set 7 V +1 CR +1 10/17/23, 10:41

  21. Stefan Bürk voted on patch set 7 V +1 CR +1 10/17/23, 11:09

  22. Benni Mack voted on patch set 7 V +2 CR +2 10/17/23, 11:39

  23. Benni Mack merged patch set 8 10/17/23, 11:39

  24. Stephan Großberndt commented on patch set 8 10/17/23, 11:47

    Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:18

    by
  25. Benni Mack commented on patch set 8 10/30/23, 21:59

    Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:18 Reply