Review main Merged

81420[TASK] Minor optimization in bin/typo3 referenceindex:update

Christian Kuhn CR +2 V +2 Easy +5 −2 updated 10/12/23, 14:28

Commit message

Skip some queries when there are no rows in a table.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/12/23, 13:04

  2. Christian Kuhn updated the commit message in patch set 2 10/12/23, 13:10

  3. core-ci voted on patch set 1 V +1 10/12/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47717

  4. core-ci voted on patch set 2 V +1 10/12/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47718

  5. Christian Kuhn commented on patch set 2 CR -1 10/12/23, 13:25

    actually, we can do that more elegantly.
  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 10/12/23, 13:28

  7. Christian Kuhn updated the commit message in patch set 4 10/12/23, 13:28

  8. Christian Kuhn updated the commit message in patch set 5 10/12/23, 13:29

  9. Stefan Bürk voted on patch set 5 V +1 CR +1 10/12/23, 13:35

  10. core-ci voted on patch set 5 V +1 10/12/23, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47721

  11. Oliver Klee voted on patch set 5 V +1 CR +1 10/12/23, 14:08

  12. Christian Kuhn voted on patch set 5 V +2 CR +2 10/12/23, 14:28

  13. Christian Kuhn merged patch set 6 10/12/23, 14:28