81426[FEATURE] Auto DB fields from TCA for type "radio"
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php7+77 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101553-Auto-createDBFieldsFromTCAColumns.rst+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+228 −0
- typo3/sysext/core/ext_tables.sql+0 −1
Review log 2025
-
Nikita Hovratov uploaded patch set 1 10/13/23, 15:33
-
Benni Mack commented on patch set 1 10/13/23, 15:41
I'm pretty sure we also have type=radio in sys_template ? -
core-ci voted on patch set 1 V -1 10/13/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47745
-
Nikita Hovratov commented on patch set 1 10/13/23, 15:50
Reply
Hm, where?^^ -
Benni Mack commented on patch set 1 10/13/23, 16:05
Reply
ugh, nevermind :) -
Nikita Hovratov uploaded patch set 2
V -110/13/23, 16:10 -
Nikita Hovratov updated the commit message in patch set 3 10/13/23, 16:10
-
core-ci voted on patch set 3 V +1 10/13/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47747
-
Oliver Klee voted on patch set 3 V +1 10/13/23, 16:35
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 10/14/23, 07:17
-
Stefan Bürk commented on patch set 3 CR -1 10/14/23, 09:30
on it (see comments) ...DefaultTcaSchema.php:803Please let's keep that in the method above for now. Basically a good move to split out, but we want to rethink/optimize the overall re-iterating anyway - having the same schema like above makes that kind of recuring - this now "breaks that"DefaultTcaSchema.php:812I think, we can rearrange the flow here a little bit and using in-between early returns. makes reading the building more streamline and and reduces the wonky-honky left-right jumps. Hard to explain, will push it later when I'm back at the pc ... -
Christian Kuhn commented on patch set 3 10/14/23, 10:49
DefaultTcaSchema.php:803Replyyeah. let's keep the one big method for now, and we refactor at the end.DefaultTcaSchema.php:841i personally would not have gone through that, since the difference between int and smallint is just a few bytes and very most likely not relevant in our use cases. let's keep it now that we have that distinction, but it wouldn't hurt much in case we decide to drop it later. -
Stefan Bürk uploaded patch set 4
CR +1V +110/14/23, 12:12 -
Stefan Bürk commented on patch set 4 10/14/23, 12:14
DefaultTcaSchema.php:803ReplyDoneDefaultTcaSchema.php:812ReplyDoneDefaultTcaSchema.php:841ReplyHad the same thought - kept it for now. -
core-ci voted on patch set 4 V +1 10/14/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47754
-
Stefan Bürk uploaded patch set 5
V +110/14/23, 12:21 -
Stefan Bürk voted on patch set 5 V +1 CR +1 10/14/23, 12:23
-
Stefan Bürk commented on patch set 6
CR +1V +110/14/23, 12:27Published edit on patch set 5. -
Stefan Bürk voted on patch set 6 V +1 CR +1 10/14/23, 12:28
-
core-ci voted on patch set 5 V +1 10/14/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47755
-
core-ci voted on patch set 6 V +1 10/14/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47757
-
Christian Kuhn voted on patch set 6 V +1 CR +1 10/15/23, 10:28
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 10/16/23, 04:06
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 10/16/23, 07:43
-
Nikita Hovratov merged patch set 7 10/16/23, 07:43