Review main Merged

81427[FEATURE] Auto create DB fields from TCA for type "link"

Anja Leichsenring CR +2 V +2 Normal +137 −73 updated 10/16/23, 09:05

Commit message

Tables with TCA columns set to type="link" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=link.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 1420

  1. Anja Leichsenring uploaded patch set 1 10/14/23, 08:02

  2. core-ci voted on patch set 1 V -1 10/14/23, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47752

  3. Anja Leichsenring uploaded patch set 2 V -1 10/14/23, 08:59

  4. core-ci voted on patch set 2 V +1 10/14/23, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47753

  5. Christian Kuhn voted on patch set 2 CR +1 10/14/23, 10:53

  6. Anja Leichsenring uploaded patch set 3 CR +1 V +1 10/14/23, 13:51

  7. core-ci voted on patch set 3 V -1 10/14/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47760

  8. Anja Leichsenring uploaded patch set 4 V -1 10/16/23, 04:05

  9. core-ci voted on patch set 4 V +1 10/16/23, 04:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47800

  10. Georg Ringer commented on patch set 4 10/16/23, 05:51

    entry in Feature-101553-Auto-createDBFieldsFromTCAColumns.rst missing?
  11. Anja Leichsenring updated the commit message in patch set 5 V +1 10/16/23, 07:48

  12. Anja Leichsenring uploaded patch set 6 10/16/23, 07:55

  13. Anja Leichsenring commented on patch set 5 10/16/23, 07:55

    Reply

    yes. thanks for spotting
  14. core-ci voted on patch set 5 V +1 10/16/23, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47805

  15. core-ci voted on patch set 6 V +1 10/16/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47806

  16. Georg Ringer voted on patch set 6 V +1 CR +1 10/16/23, 08:11

  17. Oliver Klee voted on patch set 6 V +1 10/16/23, 08:58

  18. Oliver Klee voted on patch set 6 CR +1 10/16/23, 09:00

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 10/16/23, 09:05

  20. Christian Kuhn merged patch set 7 10/16/23, 09:05