81429[BUGFIX] Avoid GU::trimExplode('', null) in BU::getProcessedValue()
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1315
-
Christian Kuhn uploaded patch set 1 10/15/23, 10:42
-
core-ci voted on patch set 1 V +1 10/15/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47768
-
Oliver Klee commented on patch set 1 V +1 10/15/23, 11:13
Should we also backport it to 12.4 and 11.5 so the data is of the correct type there as well? -
Oliver Klee voted on patch set 1 CR +1 10/15/23, 11:15
-
Oliver Klee commented on patch set 1 10/15/23, 11:15
Reply
(not resolved yet) -
Christian Kuhn commented on patch set 1 10/15/23, 11:28
Reply
i'd rather keep that main-only since that's a direct regression from the main-only GU::trimExplode() patch - there is no direct need to risk any problem in v12 with this. -
Christian Kuhn commented on patch set 1 10/15/23, 11:31
ok, applies cleanly to v12 and should not hurt i suppose. -
Christian Kuhn updated the commit message in patch set 2
CR +1V +110/15/23, 11:31 -
Christian Kuhn commented on patch set 2 10/15/23, 11:31
Reply
Done -
Oliver Klee voted on patch set 2 CR +1 10/15/23, 11:34
-
core-ci voted on patch set 2 V +1 10/15/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47770
-
Oliver Klee voted on patch set 2 V +1 10/15/23, 11:41
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/15/23, 12:55
-
Stefan Bürk voted on patch set 2 V +2 CR +2 10/15/23, 13:42
-
Stefan Bürk merged patch set 3 10/15/23, 13:42