Review main Merged

81429[BUGFIX] Avoid GU::trimExplode('', null) in BU::getProcessedValue()

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/15/23, 13:42

Commit message

GeneralUtility::trimExplode() needs a string since #101453
as second argument. TCA type=folder DB values can be null,
which can be triggered for instance by bootstrap_package
in BackendUtility::getProcessedValue().
Cast the value before feeding it to GU::trimExplode().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1315

  1. Christian Kuhn uploaded patch set 1 10/15/23, 10:42

  2. core-ci voted on patch set 1 V +1 10/15/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47768

  3. Oliver Klee commented on patch set 1 V +1 10/15/23, 11:13

    Should we also backport it to 12.4 and 11.5 so the data is of the correct type there as well?
  4. Oliver Klee voted on patch set 1 CR +1 10/15/23, 11:15

  5. Oliver Klee commented on patch set 1 10/15/23, 11:15

    Reply

    (not resolved yet)
  6. Christian Kuhn commented on patch set 1 10/15/23, 11:28

    Reply

    i'd rather keep that main-only since that's a direct regression from the main-only GU::trimExplode() patch - there is no direct need to risk any problem in v12 with this.
  7. Christian Kuhn commented on patch set 1 10/15/23, 11:31

    ok, applies cleanly to v12 and should not hurt i suppose.
  8. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 10/15/23, 11:31

  9. Christian Kuhn commented on patch set 2 10/15/23, 11:31

    Reply

    Done
  10. Oliver Klee voted on patch set 2 CR +1 10/15/23, 11:34

  11. core-ci voted on patch set 2 V +1 10/15/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47770

  12. Oliver Klee voted on patch set 2 V +1 10/15/23, 11:41

  13. Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/15/23, 12:55

  14. Stefan Bürk voted on patch set 2 V +2 CR +2 10/15/23, 13:42

  15. Stefan Bürk merged patch set 3 10/15/23, 13:42