Review 12.4 Merged

81430[BUGFIX] Avoid GU::trimExplode('', null) in BU::getProcessedValue()

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/15/23, 13:43

Commit message

GeneralUtility::trimExplode() needs a string since #101453
as second argument. TCA type=folder DB values can be null,
which can be triggered for instance by bootstrap_package
in BackendUtility::getProcessedValue().
Cast the value before feeding it to GU::trimExplode().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/15/23, 11:31

  2. Oliver Klee voted on patch set 1 CR +1 10/15/23, 11:34

  3. Oliver Klee voted on patch set 1 V +1 10/15/23, 11:43

  4. core-ci voted on patch set 1 V +1 10/15/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47771

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 10/15/23, 13:43

  6. Stefan Bürk merged patch set 2 10/15/23, 13:43