Review main Merged Breaking

81436[!!!][TASK] Drastically speed up `bin/typo3 cleanup:flexforms`

Christian Kuhn CR +2 V +2 Hard +133 −217 updated 10/17/23, 09:08

Commit message

CLI command `bin/typo3 cleanup:flexforms` of ext:lowlevel
is extremely slow due to its page-tree-based strategy.
It can run many hours on seasoned instances.

Rewriting the command towards a TCA table
based approach speeds it up dramatically.

Example data point with my tiny test DB: Before ~450
seconds, with patch ~0.5 seconds.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1421

  1. Christian Kuhn uploaded patch set 1 10/16/23, 14:34

  2. core-ci voted on patch set 1 V +1 10/16/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47825

  3. Christian Kuhn uploaded patch set 2 V +1 10/16/23, 15:04

  4. Oliver Klee updated the commit message in patch set 3 10/16/23, 15:06

  5. core-ci voted on patch set 2 V +1 10/16/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47828

  6. core-ci voted on patch set 3 V +1 10/16/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47829

  7. core-ci voted on patch set 3 V -1 10/16/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47830

  8. Stefan Bürk rebased onto patch set 4 V -1 10/16/23, 16:09

  9. core-ci voted on patch set 4 V +1 10/16/23, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47832

  10. core-ci commented on patch set 4 10/16/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47833

  11. Kevin Appelt voted on patch set 4 CR +1 10/16/23, 17:03

  12. Simon Schaufelberger commented on patch set 4 10/16/23, 17:20

    CleanFlexFormsCommand.php:102

    i guess a comparison with empty string would be even faster.
  13. Christian Kuhn commented on patch set 4 10/16/23, 18:27

    CleanFlexFormsCommand.php:102 Reply

    true but micro-optimization. the important thing here is the string cast to skip on null.
  14. Christian Kuhn uploaded patch set 5 CR +1 V +1 10/16/23, 18:28

  15. Christian Kuhn commented on patch set 4 10/16/23, 18:28

    CleanFlexFormsCommand.php:102 Reply

    Done
  16. core-ci voted on patch set 5 V +1 10/16/23, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47836

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 10/16/23, 18:48

  18. Benni Mack voted on patch set 5 V +1 CR +1 10/17/23, 07:32

  19. Garvin Hicking commented on patch set 5 V +1 CR +1 10/17/23, 08:22

    Works great!
  20. Christian Kuhn voted on patch set 5 V +2 CR +2 10/17/23, 09:08

  21. Christian Kuhn merged patch set 6 10/17/23, 09:08