81436[!!!][TASK] Drastically speed up `bin/typo3 cleanup:flexforms`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102181-RemovedCLIOptionsUsingBintypo3Cleanupflexforms.rstnew+52 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php3+79 −215
- typo3/sysext/lowlevel/Configuration/Services.yaml+1 −1
Review log 1421
-
Christian Kuhn uploaded patch set 1 10/16/23, 14:34
-
core-ci voted on patch set 1 V +1 10/16/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47825
-
Christian Kuhn uploaded patch set 2
V +110/16/23, 15:04 -
Oliver Klee updated the commit message in patch set 3 10/16/23, 15:06
-
core-ci voted on patch set 2 V +1 10/16/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47828
-
core-ci voted on patch set 3 V +1 10/16/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47829
-
core-ci voted on patch set 3 V -1 10/16/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47830
-
Stefan Bürk rebased onto patch set 4
V -110/16/23, 16:09 -
core-ci voted on patch set 4 V +1 10/16/23, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47832
-
core-ci commented on patch set 4 10/16/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47833
-
Kevin Appelt voted on patch set 4 CR +1 10/16/23, 17:03
-
Simon Schaufelberger commented on patch set 4 10/16/23, 17:20
-
Christian Kuhn commented on patch set 4 10/16/23, 18:27
CleanFlexFormsCommand.php:102Replytrue but micro-optimization. the important thing here is the string cast to skip on null. -
Christian Kuhn uploaded patch set 5
CR +1V +110/16/23, 18:28 -
Christian Kuhn commented on patch set 4 10/16/23, 18:28
CleanFlexFormsCommand.php:102ReplyDone -
core-ci voted on patch set 5 V +1 10/16/23, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47836
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/16/23, 18:48
-
Benni Mack voted on patch set 5 V +1 CR +1 10/17/23, 07:32
-
Garvin Hicking commented on patch set 5 V +1 CR +1 10/17/23, 08:22
Works great! -
Christian Kuhn voted on patch set 5 V +2 CR +2 10/17/23, 09:08
-
Christian Kuhn merged patch set 6 10/17/23, 09:08
CleanFlexFormsCommand.php:102