81437[TASK] Remove pre-FAL code from getImgResource
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1114
-
Benni Mack uploaded patch set 1 10/16/23, 15:43
-
core-ci voted on patch set 1 V -1 10/16/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47831
-
Benni Mack uploaded patch set 2
V -110/16/23, 18:47 -
core-ci voted on patch set 2 V +1 10/16/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47838
-
Stefan Bürk commented on patch set 2 V +1 CR +1 10/17/23, 11:36
Tried hard, could not trigger that piece of code either. -
Christian Kuhn commented on patch set 2 10/17/23, 11:55
ContentObjectRendererTest.php:409let's drop that test to prevent this awful mocking party. -
Christian Kuhn uploaded patch set 3
CR +1V +110/17/23, 11:58 -
core-ci voted on patch set 3 V +1 10/17/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47864
-
Andreas Kienast voted on patch set 3 V +1 CR +1 10/17/23, 12:30
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/17/23, 12:38
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/17/23, 12:38
-
Markus Klein voted on patch set 3 CR +1 10/17/23, 12:39
-
Benni Mack voted on patch set 3 V +2 CR +2 10/17/23, 13:07
-
Benni Mack merged patch set 4 10/17/23, 13:07