Review main Merged

81437[TASK] Remove pre-FAL code from getImgResource

Benni Mack CR +2 V +2 Normal +0 −61 updated 10/17/23, 13:07

Commit message

One piece of code within ContentObjectRenderer
was kept when File Abstraction Layer was not able
to process an image.

In my test cases, I was unable to trigger this
place with the given setup. The case (dating
to pre 6.0) could stem from chaining multiple
processes of ImageMagick, which should then
occur within the processing chain of TYPO3 itself.

As it is not possible to trigger this code,
it is removed without an RST as the implications
or migrations cannot be explained.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Benni Mack uploaded patch set 1 10/16/23, 15:43

  2. core-ci voted on patch set 1 V -1 10/16/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47831

  3. Benni Mack uploaded patch set 2 V -1 10/16/23, 18:47

  4. core-ci voted on patch set 2 V +1 10/16/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47838

  5. Stefan Bürk commented on patch set 2 V +1 CR +1 10/17/23, 11:36

    Tried hard, could not trigger that piece of code either.
  6. Christian Kuhn commented on patch set 2 10/17/23, 11:55

    ContentObjectRendererTest.php:409

    let's drop that test to prevent this awful mocking party.
  7. Christian Kuhn uploaded patch set 3 CR +1 V +1 10/17/23, 11:58

  8. core-ci voted on patch set 3 V +1 10/17/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47864

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 10/17/23, 12:30

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 10/17/23, 12:38

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 10/17/23, 12:38

  12. Markus Klein voted on patch set 3 CR +1 10/17/23, 12:39

  13. Benni Mack voted on patch set 3 V +2 CR +2 10/17/23, 13:07

  14. Benni Mack merged patch set 4 10/17/23, 13:07