81439[TASK] Consistently apply ImageMagick parameters when converting
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
Benni Mack uploaded patch set 1 10/17/23, 08:00
-
core-ci voted on patch set 1 V +1 10/17/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47850
-
Benni Mack rebased onto patch set 2
V +110/17/23, 11:39 -
core-ci voted on patch set 2 V +1 10/17/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47863
-
Benni Mack uploaded patch set 3
V +110/17/23, 12:23 -
core-ci voted on patch set 3 V -1 10/17/23, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47866
-
Benni Mack commented on patch set 4
V -110/17/23, 13:11Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 10/17/23, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47867
-
Stefan Bürk voted on patch set 4 CR +1 10/18/23, 06:49
-
Stefan Bürk voted on patch set 4 V +1 10/18/23, 07:09
-
Andreas Kienast commented on patch set 4 CR -1 10/18/23, 13:14
temp, on it -
Andreas Kienast commented on patch set 4 10/18/23, 13:25
GraphicalFunctions.php:334This was previously `$params`. Changing this may cause a regression at a later point (line 364 onwards), wouldn't it? -
Benni Mack commented on patch set 4 10/18/23, 13:30
GraphicalFunctions.php:334Replythe main problem here is that IM first needs to set the scaling ($this->scalecmd) and then works in that area. $params is actually additional parameters, which should be added at the very end: If we want to crop from the values, we need to do this first. I had quite a lot of failing tests fiddling around. This patch actually serves as a basis for finally moving on with this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67234 -
Andreas Kienast commented on patch set 4 V +1 CR +1 10/18/23, 13:34
GraphicalFunctions.php:334ReplyAck -
Christian Kuhn voted on patch set 4 V +1 CR +1 10/18/23, 15:29
-
Benni Mack commented on patch set 4 V +2 CR +2 10/18/23, 16:22
thanks guys! -
Benni Mack merged patch set 5 10/18/23, 16:22