81445[TASK] Add phpstan check for unneeded pseudo uncertain instanceof usage
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 42
- Build/phpstan/src/Rules/Classes/UnneededInstanceOfRule.phpnew+84 −0
- Build/phpstan/phpstan.neon+11 −0
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+1 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+6 −14
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+4 −1
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+1 −1
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php+1 −3
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+1 −3
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php+1 −3
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −4
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+3 −5
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+1 −1
- typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php+3 −4
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php+2 −4
- typo3/sysext/core/Classes/Routing/PageRouter.php+1 −1
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+1 −1
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+1 −1
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+4 −3
Show 22 more files
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+3 −3
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+1 −5
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+13 −10
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+1 −3
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+1 −4
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+2 −3
- typo3/sysext/frontend/Classes/Controller/ErrorController.php+4 −4
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/SiteBaseRedirectResolver.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −14
- typo3/sysext/impexp/Classes/Controller/ExportController.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ImportController.php+2 −3
- typo3/sysext/impexp/Classes/Export.php+1 −1
- typo3/sysext/install/Classes/Middleware/Maintenance.php+1 −1
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php+4 −4
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+25 −25
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+1 −8
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+3 −3
- composer.json+2 −1
Review log 34
-
Benjamin Franzke uploaded patch set 1 10/18/23, 07:09
-
core-ci voted on patch set 1 V +1 10/18/23, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47891
-
Benjamin Franzke commented on patch set 1 V +2 CR +2 10/18/23, 08:28
This change is ready for review. -
Benjamin Franzke merged patch set 2 10/18/23, 08:28