Review main Merged

81446[BUGFIX] Allow to create folders with name "0"

Justus Moroni CR +2 V +2 Easy +1 −1 updated 11/05/23, 19:04

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1619

  1. Justus Moroni uploaded patch set 1 10/18/23, 08:30

  2. Daniel Siepmann voted on patch set 1 V +1 CR +1 10/18/23, 08:31

  3. Mathias Brodala commented on patch set 1 CR -1 10/18/23, 08:34

    ExtendedFileUtility.php:230

    This will now throw a notice in case this array key is undefined. Please add a "?? null" or similar here.
  4. core-ci voted on patch set 1 V +1 10/18/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47894

  5. Justus Moroni uploaded patch set 2 CR +1 V +1 10/18/23, 08:47

  6. Daniel Siepmann voted on patch set 2 V +1 10/18/23, 08:48

  7. Justus Moroni commented on patch set 2 10/18/23, 08:48

    ExtendedFileUtility.php:230 Reply

    Done
  8. Mathias Brodala voted on patch set 2 CR +1 10/18/23, 08:50

  9. core-ci voted on patch set 2 V +1 10/18/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47897

  10. Oliver Klee commented on patch set 2 10/18/23, 09:03

    I propose also backporting this to 11.5 (as the affected code is present there as well).
  11. Oliver Hader commented on patch set 2 10/18/23, 13:52

    Reply

    This behavior seems to exist since 2014 and has not been that important since then...

    ExtendedFileUtility.php:230

    I guess it should be string casted...
  12. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 11/03/23, 12:50

  13. Simon Schaufelberger commented on patch set 3 V +1 CR +1 11/03/23, 12:50

    ExtendedFileUtility.php:230 Reply

    Done
  14. Oliver Klee voted on patch set 3 CR +1 11/03/23, 12:51

  15. Oliver Hader voted on patch set 3 CR +1 11/03/23, 12:56

  16. core-ci voted on patch set 3 V +1 11/03/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48546

  17. Andreas Kienast voted on patch set 3 CR +1 11/03/23, 13:27

  18. Benni Mack voted on patch set 3 V +2 CR +2 11/05/23, 19:04

  19. Benni Mack merged patch set 4 11/05/23, 19:04