Review main Merged

81451[TASK] Replace tabs with spaces in xml files

Nikita Hovratov CR +2 V +2 Impossible +15700 −15700 updated 10/20/23, 10:57

Commit message

In order to align with the current specification of .editorconfig, all
xml files inside typo3/sysext and Build have their tabs replaced with 4
spaces.

Executed commands:

find ./typo3/sysext/ -type f -name "*.xml" \
-exec sed -i 's/\t/    /g' {} \;

find ./Build -name "*.xml" -not -path "./Build/node_modules/*" \
-exec sed -i 's/\t/    /g' {} \;

Note: Manual adjustment in some impexp fixtures have been done to
keep tabs as there is a database version of FlexForm stored.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 41

Show 21 more files

Review log 1418

  1. Nikita Hovratov uploaded patch set 1 10/18/23, 15:19

  2. core-ci voted on patch set 1 V -1 10/18/23, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47914

  3. Oliver Klee commented on patch set 1 10/18/23, 15:36

    It looks like some fixtures need to keep using tabs for the tests to pass.
  4. Nikita Hovratov uploaded patch set 2 V -1 10/18/23, 16:21

  5. Nikita Hovratov commented on patch set 2 10/18/23, 16:22

    Reply

    Yes, at least a part of it. It's not so easy to adjust the regex for this, so I edited it manually.
  6. core-ci voted on patch set 2 V -1 10/18/23, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47915

  7. Nikita Hovratov uploaded patch set 3 V -1 10/18/23, 16:39

  8. core-ci voted on patch set 3 V +1 10/18/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47918

  9. Oliver Klee voted on patch set 3 V +1 CR +1 10/19/23, 08:04

  10. Nikita Hovratov uploaded patch set 4 CR +1 V +1 10/20/23, 09:11

  11. core-ci voted on patch set 4 V +1 10/20/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47960

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/20/23, 09:23

  13. Oliver Klee voted on patch set 4 V +1 CR +1 10/20/23, 09:28

  14. Jasmina Ließmann voted on patch set 4 V +1 CR +1 10/20/23, 09:29

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 10/20/23, 10:12

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 10/20/23, 10:26

  17. Nikita Hovratov voted on patch set 4 V +2 CR +2 10/20/23, 10:57

  18. Nikita Hovratov merged patch set 5 10/20/23, 10:57