81477[TASK] Escape dynamic values in DOM selectors
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 57
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+10 −9
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+3 −2
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+10 −9
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+7 −6
- Build/Sources/TypeScript/backend/form-engine/element/abstract-sortable-select-items.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine/element/category-element.ts+3 −2
- Build/Sources/TypeScript/backend/form-engine/element/color-element.ts+7 −2
- Build/Sources/TypeScript/backend/form-engine/element/folder-element.ts+6 −1
- Build/Sources/TypeScript/backend/form-engine/element/link-element.ts+7 −1
- Build/Sources/TypeScript/backend/form-engine/element/mfa-info-element.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine/element/password-element.ts+10 −3
- Build/Sources/TypeScript/backend/form-engine/element/select-single-element.ts+4 −3
- Build/Sources/TypeScript/backend/viewport/navigation-container.ts+2 −1
- Build/Sources/TypeScript/backend/context-menu.ts+2 −1
- Build/Sources/TypeScript/backend/document-save-actions.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-review.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-suggest.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+8 −7
- Build/Sources/TypeScript/backend/form-engine.ts+19 −17
- Build/Sources/TypeScript/backend/grid-editor.ts+2 −1
Show 37 more files
- Build/Sources/TypeScript/backend/module-menu.ts+3 −2
- Build/Sources/TypeScript/backend/multi-record-selection.ts+3 −2
- Build/Sources/TypeScript/backend/recordlist.ts+3 −2
- Build/Sources/TypeScript/core/tests/literals-test.tsnew+24 −0
- Build/Sources/TypeScript/core/literals.tsnew+17 −0
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+3 −2
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+2 −1
- Build/Sources/TypeScript/install/installer.ts+2 −1
- Build/Sources/TypeScript/workspaces/backend.ts+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/abstract-sortable-select-items.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/category-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/color-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/folder-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/link-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/mfa-info-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/password-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-single-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/navigation-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/document-save-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-suggest.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/literals.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 1930
Show 35 earlier messages
-
Benjamin Franzke uploaded patch set 1 10/19/23, 09:37
-
core-ci voted on patch set 1 V -1 10/19/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47931
-
Benjamin Franzke uploaded patch set 2
V -110/19/23, 11:03 -
core-ci voted on patch set 2 V -1 10/19/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47934
-
Benjamin Franzke uploaded patch set 3
V -110/19/23, 11:27
-
Andreas Kienast commented on patch set 3 CR -1 10/19/23, 11:30
This patch apparently misses usages of `document.querySelectorAll()`. One candidate would be `Build/Sources/TypeScript/backend/multi-record-selection.ts`, method `getCombinedSelector()` -
core-ci voted on patch set 3 V -1 10/19/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47935
-
Benjamin Franzke commented on patch set 3 10/19/23, 11:47
Reply
ack, and jquery selectors. -
Benjamin Franzke marked it work in progress 10/19/23, 11:47
-
Benjamin Franzke uploaded patch set 4
CR -1V -110/20/23, 06:22 -
core-ci voted on patch set 4 V -1 10/20/23, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47954
-
core-ci commented on patch set 4 10/20/23, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47954
-
Benjamin Franzke updated the commit message in patch set 5
V -110/20/23, 11:41 -
core-ci voted on patch set 5 V -1 10/20/23, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47967
-
Benjamin Franzke uploaded patch set 6
V -110/20/23, 12:08 -
core-ci voted on patch set 6 V +1 10/20/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47971
-
Benjamin Franzke uploaded patch set 7
V +110/21/23, 13:01 -
Benjamin Franzke uploaded patch set 8 10/21/23, 13:06
-
core-ci voted on patch set 7 V -1 10/21/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48005
-
core-ci voted on patch set 8 V -1 10/21/23, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48006
-
Benjamin Franzke uploaded patch set 9
V -110/23/23, 06:19 -
Benjamin Franzke commented on patch set 9 10/23/23, 06:20
Reply
Done -
core-ci voted on patch set 9 V +1 10/23/23, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48063
-
Benjamin Franzke uploaded patch set 10
V +110/27/23, 04:48Rebase -
core-ci voted on patch set 10 V +1 10/27/23, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48276
-
Benni Mack voted on patch set 10 CR +1 10/27/23, 06:39
-
Andreas Kienast voted on patch set 10 V +1 CR +1 10/27/23, 07:46
-
Benni Mack voted on patch set 10 V +1 10/30/23, 15:53
-
Benjamin Franzke voted on patch set 10 V +2 CR +2 10/30/23, 16:25
-
Benjamin Franzke merged patch set 11 10/30/23, 16:25