Review main Merged

81477[TASK] Escape dynamic values in DOM selectors

Benjamin Franzke CR +2 V +2 Hard +209 −108 updated 10/30/23, 16:25

Commit message

Use a string literal to automatically apply escaping
to variables via selector``. The is essentially
a formatted string with integrated escaping.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 57

Show 37 more files

Review log 1930

Show 35 earlier messages
  1. Benjamin Franzke uploaded patch set 1 10/19/23, 09:37

  2. core-ci voted on patch set 1 V -1 10/19/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47931

  3. Benjamin Franzke uploaded patch set 2 V -1 10/19/23, 11:03

  4. core-ci voted on patch set 2 V -1 10/19/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47934

  5. Benjamin Franzke uploaded patch set 3 V -1 10/19/23, 11:27

  1. Andreas Kienast commented on patch set 3 CR -1 10/19/23, 11:30

    This patch apparently misses usages of `document.querySelectorAll()`. One candidate would be `Build/Sources/TypeScript/backend/multi-record-selection.ts`, method `getCombinedSelector()`
  2. core-ci voted on patch set 3 V -1 10/19/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47935

  3. Benjamin Franzke commented on patch set 3 10/19/23, 11:47

    Reply

    ack, and jquery selectors.
  4. Benjamin Franzke marked it work in progress 10/19/23, 11:47

  5. Benjamin Franzke uploaded patch set 4 CR -1 V -1 10/20/23, 06:22

  6. core-ci voted on patch set 4 V -1 10/20/23, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47954

  7. core-ci commented on patch set 4 10/20/23, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47954

  8. Benjamin Franzke updated the commit message in patch set 5 V -1 10/20/23, 11:41

  9. core-ci voted on patch set 5 V -1 10/20/23, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47967

  10. Benjamin Franzke uploaded patch set 6 V -1 10/20/23, 12:08

  11. core-ci voted on patch set 6 V +1 10/20/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47971

  12. Benjamin Franzke uploaded patch set 7 V +1 10/21/23, 13:01

  13. Benjamin Franzke uploaded patch set 8 10/21/23, 13:06

  14. core-ci voted on patch set 7 V -1 10/21/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48005

  15. core-ci voted on patch set 8 V -1 10/21/23, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48006

  16. Benjamin Franzke uploaded patch set 9 V -1 10/23/23, 06:19

  17. Benjamin Franzke commented on patch set 9 10/23/23, 06:20

    Reply

    Done
  18. core-ci voted on patch set 9 V +1 10/23/23, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48063

  19. Benjamin Franzke uploaded patch set 10 V +1 10/27/23, 04:48

    Rebase
  20. core-ci voted on patch set 10 V +1 10/27/23, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48276

  21. Benni Mack voted on patch set 10 CR +1 10/27/23, 06:39

  22. Andreas Kienast voted on patch set 10 V +1 CR +1 10/27/23, 07:46

  23. Benni Mack voted on patch set 10 V +1 10/30/23, 15:53

  24. Benjamin Franzke voted on patch set 10 V +2 CR +2 10/30/23, 16:25

  25. Benjamin Franzke merged patch set 11 10/30/23, 16:25