Review main Merged

81478[DOCS] Clarify usage of "value" with "property" in <f:form.*> ViewHelpers

Simon Praetorius CR +2 V +2 Easy +1 −1 updated 10/19/23, 14:22

Commit message

It is already possible to use the "value" argument together
with "property" in form ViewHelpers. This should be reflected
in the ViewHelper documentation.

One possible use case is a form to edit a user. For the password
field you would want to define property="password", but also
value="" to not expose the current password hash to the form.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2

Issues 1

Files 1

Review log 1013

  1. Simon Praetorius uploaded patch set 1 10/19/23, 10:35

  2. Oliver Klee voted on patch set 1 V +1 CR +1 10/19/23, 10:35

  3. Simon Praetorius commented on patch set 1 10/19/23, 10:40

    How far back do we update the ViewHelper documentation?
  4. Mathias Brodala commented on patch set 1 10/19/23, 10:40

    AbstractFormFieldViewHelper.php:54

    > ... use a custom default field value instead of the object property value.
  5. core-ci voted on patch set 1 V +1 10/19/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47932

  6. Simon Praetorius uploaded patch set 2 CR +1 V +1 10/19/23, 10:45

  7. Mathias Brodala commented on patch set 2 CR +1 10/19/23, 10:49

    AbstractFormFieldViewHelper.php:54 Reply

    Done
  8. core-ci voted on patch set 2 V +1 10/19/23, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47933

  9. Garvin Hicking commented on patch set 2 V +1 CR +1 10/19/23, 11:33

    Good addition, I'd vote for backporting it as far back as possible (v11?) Suggestion for the title of this commit: [DOC] Clarify usage of "value" with "property" in <f:form.*> ViewHelpers
  10. Simon Praetorius updated the commit message in patch set 3 CR +1 V +1 10/19/23, 14:12

  11. Simon Praetorius voted on patch set 3 V +2 CR +2 10/19/23, 14:14

  12. Simon Praetorius merged patch set 4 10/19/23, 14:15

  13. core-ci voted on patch set 3 V +1 10/19/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47943