Review main Merged

81484[BUGFIX] Do not flush rootline cache when be user visits the website

Christoph Lehmann CR +2 V +2 Easy +5 −10 updated 10/23/23, 09:45

Commit message

The PreviewSimulator might turn on the includeHiddenPages flag in
VisibilityAspect due to hidden pages in current the rootline.

The flag is now taken into account when generating the rootline
cache identifier and thus the rootline cache doesn't need to get
flushed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 811

  1. Christoph Lehmann uploaded patch set 1 10/19/23, 20:58

  2. core-ci voted on patch set 1 V -1 10/19/23, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47949

  3. Christoph Lehmann uploaded patch set 2 V -1 10/19/23, 21:07

  4. core-ci voted on patch set 2 V +1 10/19/23, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47950

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/22/23, 09:55

  6. Nikita Hovratov updated the commit message in patch set 3 CR +1 V +1 10/22/23, 10:08

  7. core-ci voted on patch set 3 V +1 10/22/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48029

  8. Stefan Bürk voted on patch set 3 CR +1 10/23/23, 08:30

  9. Georg Ringer voted on patch set 3 V +1 CR +1 10/23/23, 09:23

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/23/23, 09:45

  11. Benni Mack merged patch set 4 10/23/23, 09:45