81488[FEATURE] Auto create DB fields from TCA for type "inline"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 23
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php5+71 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101553-Auto-createDBFieldsFromTCAColumns.rst+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/ext_tables.sql+0 −18
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/ext_tables.sql+0 −21
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_tables.sql+0 −18
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/ext_tables.sql+0 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/ext_tables.sql+0 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/ext_tables.sql+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+126 −0
- typo3/sysext/core/ext_tables.sql+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql+0 −9
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/ext_tables.sql+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/irre-records.xml+21 −21
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-complex.xml+100 −100
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-flexform-softrefs.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-softrefs.xml+1 −1
Review log 2537
Show 812 earlier messages
-
Anja Leichsenring uploaded patch set 1 10/20/23, 08:58
-
core-ci voted on patch set 1 V -1 10/20/23, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47959
-
Anja Leichsenring uploaded patch set 2
V -110/20/23, 09:15 -
core-ci voted on patch set 2 V +1 10/20/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47961
-
Oliver Klee voted on patch set 2 V +1 10/20/23, 09:43
-
Anja Leichsenring rebased onto patch set 3
V +110/20/23, 10:13 -
core-ci voted on patch set 3 V +1 10/20/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47964
-
Nikita Hovratov uploaded patch set 4
V +110/20/23, 11:03 -
core-ci voted on patch set 4 V +1 10/20/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47965
-
Oliver Klee voted on patch set 4 V +1 10/20/23, 11:30
-
Oliver Klee commented on patch set 4 10/20/23, 11:47
Looks very good in general! I love these "automate the SQL" kinds of changes! <3 I've added a comment on a place where we could make the code a bit more explicit.DefaultTcaSchema.php:898I'd prefer to have explicit comparisons here instead of relying on PHP's implicit conversion to boolean: ```php if (($fieldConfig['config']['MM'] ?? '') !== '' || ($fieldConfig['config']['foreign_field'] ?? '') !== '') { ``` -
Christian Kuhn commented on patch set 4 10/20/23, 12:52
DefaultTcaSchema.php:918could we extend this patch to auto create child-table foreign_field and foreign_table_field as well, if those have no or only passthrough TCA in the child table?
-
Anja Leichsenring commented on patch set 4 10/20/23, 13:33
DefaultTcaSchema.php:918ReplyAck -
Anja Leichsenring uploaded patch set 5
V +110/21/23, 05:38 -
core-ci voted on patch set 5 V +1 10/21/23, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47996
-
Oliver Klee commented on patch set 5 V +1 10/21/23, 07:34
DefaultTcaSchema.php:898ReplyDone -
Anja Leichsenring updated the commit message in patch set 6
V +110/21/23, 07:39 -
core-ci voted on patch set 6 V +1 10/21/23, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47997
-
Anja Leichsenring commented on patch set 6 10/21/23, 08:18
this is working, but not optimized yet. I want feedback about the process first. -
Anja Leichsenring uploaded patch set 7
V +110/21/23, 09:36 -
core-ci voted on patch set 7 V -1 10/21/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47998
-
Anja Leichsenring uploaded patch set 8
V -110/21/23, 10:04 -
core-ci voted on patch set 8 V +1 10/21/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47999
-
Anja Leichsenring commented on patch set 9
V +110/21/23, 13:12Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 10/21/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48007
-
Christian Kuhn uploaded patch set 10
V +110/22/23, 09:59 -
Christian Kuhn commented on patch set 10 CR -1 10/22/23, 10:00
DefaultTcaSchema.php:967that does not make sense to me. let's chat on this. -
core-ci voted on patch set 10 V +1 10/22/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48026
-
Christian Kuhn uploaded patch set 11
CR -1V +110/22/23, 10:20 -
core-ci voted on patch set 11 V +1 10/22/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48030
-
Christian Kuhn uploaded patch set 12
V +110/22/23, 10:37 -
core-ci voted on patch set 12 V +1 10/22/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48033
-
Christian Kuhn voted on patch set 12 V +1 CR +1 10/22/23, 11:35
-
Oliver Klee voted on patch set 12 V +1 10/22/23, 11:42
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 10/22/23, 12:11
-
Christian Kuhn voted on patch set 12 V +2 CR +2 10/22/23, 12:11
-
Christian Kuhn merged patch set 13 10/22/23, 12:11