Review main Merged

81491[TASK] Proper DI in FlexFormTools

Christian Kuhn CR +2 V +2 Normal +87 −136 updated 10/20/23, 13:37

Commit message

The event dispatcher should always be injected
via DI, either directly or through makeInstance().
It should not be nullable.

Switch a couple of service consumers to get an
instance injected.

Note further patches will remove left over state
properties from FlexFormTools ensuring the service
is fully stateless in the end, which is pretty
much the case already, but not obvious.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1015

  1. Christian Kuhn uploaded patch set 1 10/20/23, 11:50

  2. core-ci voted on patch set 1 V +1 10/20/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47970

  3. Christian Kuhn uploaded patch set 2 V +1 10/20/23, 12:24

  4. Christian Kuhn uploaded patch set 3 10/20/23, 12:30

  5. core-ci voted on patch set 3 V -1 10/20/23, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47973

  6. Christian Kuhn uploaded patch set 4 V -1 10/20/23, 12:42

  7. core-ci voted on patch set 4 V -1 10/20/23, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47974

  8. core-ci voted on patch set 4 V +1 10/20/23, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47974

  9. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/20/23, 13:15

  10. core-ci voted on patch set 2 V -1 10/20/23, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47972

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 10/20/23, 13:24

  12. Oliver Klee voted on patch set 4 V +1 CR +1 10/20/23, 13:28

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/20/23, 13:32

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 10/20/23, 13:36

  15. Christian Kuhn merged patch set 5 10/20/23, 13:37