Review main Merged

81498[TASK] Improve invalidArguments tests for ImageViewHelper

Nikita Hovratov CR +2 V +2 Easy +26 −12 updated 10/22/23, 10:10

Commit message

- Remove duplicate test case for src="" and image="null"
- Avoid instantiating ImageViewHelper with "new" -> use TemplateView
- Add missing scenarios for possible exceptions

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Nikita Hovratov uploaded patch set 1 10/21/23, 21:18

  2. core-ci voted on patch set 1 V +1 10/21/23, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48017

  3. Oliver Klee voted on patch set 1 V +1 CR +1 10/22/23, 08:20

  4. Benni Mack voted on patch set 1 V +1 CR +1 10/22/23, 08:42

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/22/23, 09:44

  6. Nikita Hovratov merged patch set 2 10/22/23, 09:44

  7. Christian Kuhn commented on patch set 2 10/22/23, 09:57

    ImageViewHelperTest.php:38

    please avoid misusing a csv of a different test here, it's better to copy that one around instead.
  8. Nikita Hovratov commented on patch set 2 10/22/23, 10:10

    ImageViewHelperTest.php:38 Reply

    Done