Review main Merged

81499[BUGFIX] Allow WS preview links to preview hidden pages

Benni Mack CR +2 V +2 Easy +5 −2 updated 11/23/23, 20:44

Commit message

When a hidden page is previewed in the Backend,
the PreviewSimulator has a valid BE_USER object
in place. However, when a preview link is generated,
the PreviewUser does not have a group, thus the PreviewSimulator
is not activated.

For this reason, the check if the PreviewSimulator
is active, needs to consider if we are in an offline workspace

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Wolf +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 10/22/23, 09:06

  2. core-ci voted on patch set 1 V +1 10/22/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48022

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/02/23, 17:00

  4. Andreas Wolf voted on patch set 1 CR +1 V +1 11/23/23, 19:25

  5. Benni Mack voted on patch set 1 CR +2 V +2 11/23/23, 20:44

  6. Benni Mack merged patch set 2 11/23/23, 20:44