81500[TASK] Avoid misusing csv file of different test in ImageViewHelperTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1519
-
Nikita Hovratov uploaded patch set 1 10/22/23, 10:05
-
core-ci voted on patch set 1 V +1 10/22/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48027
-
Oliver Klee voted on patch set 1 V +1 10/22/23, 10:21
-
Oliver Klee voted on patch set 1 CR +1 10/22/23, 10:21
-
Nikita Hovratov uploaded patch set 2
CR +1V +110/22/23, 10:22 -
Nikita Hovratov uploaded patch set 3 10/22/23, 10:29
-
core-ci voted on patch set 2 V +1 10/22/23, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48031
-
core-ci voted on patch set 3 V +1 10/22/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48032
-
Oliver Klee commented on patch set 3 10/22/23, 10:44
-
Nikita Hovratov commented on patch set 3 10/22/23, 11:06
ImageViewHelperTest.php:45ReplyI can reword the commit message if you insist, but let's have it in one go. You can see it as a follow-up patch. I should have added the error messages in the cleanup beforehand. -
Nikita Hovratov updated the commit message in patch set 4
V +110/22/23, 11:09 -
core-ci voted on patch set 4 V +1 10/22/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48034
-
Oliver Klee commented on patch set 4 V +1 CR +1 10/22/23, 11:39
ImageViewHelperTest.php:45ReplyAck -
Christian Kuhn commented on patch set 4 CR -1 10/22/23, 11:42
ImageViewHelperTest.php:82we usually don't check for exception message in tests - that's too brittle. we instead check for the exception class (which you do), plus the exception code (which you do, too) -> remove exceptionMessage, imho. -
Christian Kuhn commented on patch set 4 CR 0 10/22/23, 11:49
ImageViewHelperTest.php:82Replyscratch that. the messages are from the catch blocks. so ok with me to have that here exceptionally. -
Christian Kuhn voted on patch set 4 V +1 CR +1 10/22/23, 11:49
-
Christian Kuhn commented on patch set 4 10/22/23, 11:50
ImageViewHelperTest.php:82Replyat least they are kinda useful to check in this case ... -
Nikita Hovratov commented on patch set 4 V +2 CR +2 10/22/23, 11:51
thanks! -
Nikita Hovratov merged patch set 5 10/22/23, 11:51
ImageViewHelperTest.php:45