Review main Merged

81500[TASK] Avoid misusing csv file of different test in ImageViewHelperTest

Nikita Hovratov CR +2 V +2 Easy +33 −13 updated 10/22/23, 11:51

Commit message

This is a follow-up patch for #102220. A dedicated fileadmin path has
been added for ImageViewHelperTest and unnecessary fixtures are removed.

In addition, error message checks are added for the invalidArgument
test cases in order to clarify, what exactly is supposed to go wrong.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1519

  1. Nikita Hovratov uploaded patch set 1 10/22/23, 10:05

  2. core-ci voted on patch set 1 V +1 10/22/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48027

  3. Oliver Klee voted on patch set 1 V +1 10/22/23, 10:21

  4. Oliver Klee voted on patch set 1 CR +1 10/22/23, 10:21

  5. Nikita Hovratov uploaded patch set 2 CR +1 V +1 10/22/23, 10:22

  6. Nikita Hovratov uploaded patch set 3 10/22/23, 10:29

  7. core-ci voted on patch set 2 V +1 10/22/23, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48031

  8. core-ci voted on patch set 3 V +1 10/22/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48032

  9. Oliver Klee commented on patch set 3 10/22/23, 10:44

    ImageViewHelperTest.php:45

    This cleanup looks unrelated to me. I’d prefer to have it in a separate change.
  10. Nikita Hovratov commented on patch set 3 10/22/23, 11:06

    ImageViewHelperTest.php:45 Reply

    I can reword the commit message if you insist, but let's have it in one go. You can see it as a follow-up patch. I should have added the error messages in the cleanup beforehand.
  11. Nikita Hovratov updated the commit message in patch set 4 V +1 10/22/23, 11:09

  12. core-ci voted on patch set 4 V +1 10/22/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48034

  13. Oliver Klee commented on patch set 4 V +1 CR +1 10/22/23, 11:39

    ImageViewHelperTest.php:45 Reply

    Ack
  14. Christian Kuhn commented on patch set 4 CR -1 10/22/23, 11:42

    ImageViewHelperTest.php:82

    we usually don't check for exception message in tests - that's too brittle. we instead check for the exception class (which you do), plus the exception code (which you do, too) -> remove exceptionMessage, imho.
  15. Christian Kuhn commented on patch set 4 CR 0 10/22/23, 11:49

    ImageViewHelperTest.php:82 Reply

    scratch that. the messages are from the catch blocks. so ok with me to have that here exceptionally.
  16. Christian Kuhn voted on patch set 4 V +1 CR +1 10/22/23, 11:49

  17. Christian Kuhn commented on patch set 4 10/22/23, 11:50

    ImageViewHelperTest.php:82 Reply

    at least they are kinda useful to check in this case ...
  18. Nikita Hovratov commented on patch set 4 V +2 CR +2 10/22/23, 11:51

    thanks!
  19. Nikita Hovratov merged patch set 5 10/22/23, 11:51