Review main Merged Breaking

81503[!!!][TASK] Avoid TemplaVoila related FlexForm details

Christian Kuhn CR +2 V +2 Expert +106 −1003 updated 10/22/23, 15:36

Commit message

A simple TCA flex form definition in extensions simply uses
the TCA 'ds' 'default' key to declare its data structure.

tt_content is a bit more complex here, it uses 'ds' with
a comma separated match list of two fields (ctype,list_type),
defined by a 'ds_pointerField' combination to look up 'ds'
keys. This is typically shadowed away for extension
developers using EMU::addPiFlexFormValue().

But there is more: 'ds_pointerField_searchParent',
'ds_pointerField_searchParent_subField' and
'ds_tableField': Those allow looking up the specific
data structure of a flex form field by having the
data structure stored in a different table, including
tree traversal functionality.

These three config options have been implemented for
TemplaVoila back in the old days. In practice *nobody*
uses these core features, even the templavoila extension
forks don't use the core implementation since they come
with xclass'es of FlexFormTools, or implement the
events.

To reduce complexity, this patch now removes handling of
these three TCA options.

Note we don't migrate the TCA definitions away to not
add not needed headaches for extensions implementing
functionality on top of it. They are just not handled in
core anymore, handling can be continued by implementing
the data structure related events.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1016

  1. Christian Kuhn uploaded patch set 1 10/22/23, 13:15

  2. core-ci voted on patch set 1 V -1 10/22/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48040

  3. Christian Kuhn uploaded patch set 2 V -1 10/22/23, 13:43

  4. core-ci voted on patch set 2 V +1 10/22/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48041

  5. Christian Kuhn uploaded patch set 3 V +1 10/22/23, 14:04

  6. Christian Kuhn commented on patch set 3 CR -1 10/22/23, 14:05

    .rst
  7. core-ci voted on patch set 3 V +1 10/22/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48042

  8. Christian Kuhn uploaded patch set 4 CR -1 V +1 10/22/23, 14:37

  9. core-ci voted on patch set 4 V -1 10/22/23, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48045

  10. Christian Kuhn uploaded patch set 5 V -1 10/22/23, 14:45

  11. core-ci voted on patch set 5 V -1 10/22/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48046

  12. core-ci voted on patch set 5 V +1 10/22/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48046

  13. Anja Leichsenring voted on patch set 5 V +1 CR +1 10/22/23, 15:20

  14. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/22/23, 15:33

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 10/22/23, 15:36

  16. Christian Kuhn merged patch set 6 10/22/23, 15:36