Review main Merged Breaking

81504[!!!][TASK] Remove FlexFormTools traverser

Christian Kuhn CR +2 V +2 Hard +321 −418 updated 10/23/23, 16:49

Commit message

With various pre-patches being done, the ugly traverser
method FlexFormTools->traverseFlexFormXMLData() is
obsolete.

This final patch to FlexFormTools removes that method
and its helper from the codebase. We're actively
removing the method and skip a deprecation phase in
this case: First, the method is low level and usually
not used by extension developers. Extensions like
the TemplaVoila forks have their own implementations
of FlexFormTools already, their migration is straight
forward. Secondly, we probably want to further simplify
FlexForm related details, maintaining the old traverser
would be a hindrance since it's so hard to follow.

FlexFormTools is now a stateless service. The patch
comes with a .rst file mentioning the changes, and
documents some details from previous patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1116

  1. Christian Kuhn uploaded patch set 1 10/22/23, 16:25

  2. Christian Kuhn uploaded patch set 2 10/22/23, 16:28

  3. Christian Kuhn uploaded patch set 3 10/22/23, 16:30

  4. Christian Kuhn uploaded patch set 4 10/22/23, 16:34

  5. core-ci voted on patch set 1 V +1 10/22/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48049

  6. core-ci voted on patch set 2 V +1 10/22/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48050

  7. core-ci voted on patch set 3 V +1 10/22/23, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48051

  8. core-ci voted on patch set 4 V +1 10/22/23, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48052

  9. Christian Kuhn uploaded patch set 5 V +1 10/23/23, 10:26

  10. core-ci voted on patch set 5 V +1 10/23/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48080

  11. Benni Mack voted on patch set 5 CR -1 10/23/23, 11:03

  12. Benni Mack voted on patch set 5 V +1 CR +1 10/23/23, 14:32

  13. Stefan Bürk voted on patch set 5 CR -1 10/23/23, 15:16

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 10/23/23, 15:31

  15. Benni Mack voted on patch set 5 V +2 CR +2 10/23/23, 16:49

  16. Benni Mack merged patch set 6 10/23/23, 16:49