81507[TASK] Simplify ImageProcessingInstruction object
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+10 −12
- typo3/sysext/core/Classes/Imaging/ImageDimension.php+10 −20
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php+23 −27
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessingInstructionsTest.php+36 −20
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+1 −3
Review log 1015
-
Benni Mack uploaded patch set 1 10/23/23, 06:47
-
core-ci voted on patch set 1 V -1 10/23/23, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48065
-
Benni Mack uploaded patch set 2
V -110/23/23, 07:26 -
core-ci voted on patch set 2 V -1 10/23/23, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48066
-
Benni Mack uploaded patch set 3
V -110/23/23, 07:43 -
Benni Mack uploaded patch set 4 10/23/23, 07:50
-
core-ci voted on patch set 3 V +1 10/23/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48067
-
core-ci voted on patch set 4 V +1 10/23/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48068
-
Stefan Bürk voted on patch set 4 CR +1 10/23/23, 08:04
-
Stefan Bürk updated the commit message in patch set 5
CR +1V +110/23/23, 08:16 -
Stefan Bürk voted on patch set 5 V +1 CR +1 10/23/23, 08:16
-
core-ci voted on patch set 5 V +1 10/23/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48070
-
Oliver Klee voted on patch set 5 V +1 CR +1 10/23/23, 08:52
-
Stefan Bürk voted on patch set 5 V +2 CR +2 10/23/23, 09:16
-
Stefan Bürk merged patch set 6 10/23/23, 09:16