Review main Merged

81507[TASK] Simplify ImageProcessingInstruction object

Benni Mack CR +2 V +2 Normal +82 −84 updated 10/23/23, 09:16

Commit message

The introduction of the ImageProcessing object
made it possible to refactor and clean up further
code within TYPO3's Image processing lowlevel code.

This change removes some previously added
arguments and options such as the file extension,
which needs to go into a separate resolver functionality.

In the same effort, the logic and usage of the infamous
$info array is reduced, and a drive-by fix for adding
the quality parameter multiple times (happened in
one of the previous refactorings) is added.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1015

  1. Benni Mack uploaded patch set 1 10/23/23, 06:47

  2. core-ci voted on patch set 1 V -1 10/23/23, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48065

  3. Benni Mack uploaded patch set 2 V -1 10/23/23, 07:26

  4. core-ci voted on patch set 2 V -1 10/23/23, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48066

  5. Benni Mack uploaded patch set 3 V -1 10/23/23, 07:43

  6. Benni Mack uploaded patch set 4 10/23/23, 07:50

  7. core-ci voted on patch set 3 V +1 10/23/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48067

  8. core-ci voted on patch set 4 V +1 10/23/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48068

  9. Stefan Bürk voted on patch set 4 CR +1 10/23/23, 08:04

  10. Stefan Bürk updated the commit message in patch set 5 CR +1 V +1 10/23/23, 08:16

  11. Stefan Bürk voted on patch set 5 V +1 CR +1 10/23/23, 08:16

  12. core-ci voted on patch set 5 V +1 10/23/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48070

  13. Oliver Klee voted on patch set 5 V +1 CR +1 10/23/23, 08:52

  14. Stefan Bürk voted on patch set 5 V +2 CR +2 10/23/23, 09:16

  15. Stefan Bürk merged patch set 6 10/23/23, 09:16