Review main Merged

81512[TASK] Bump friendsofphp/php-cs-fixer:^3.35.1

Christian Kuhn CR +2 V +2 Nightmare +1322 −3080 updated 10/23/23, 23:41

Commit message

It's time to update to latest changes of php-cs-fixer
to align with current community rules. This brings a
rather huge series of changes, main changes due to
single_line_empty_body rule which now formats empty
class and method body curly braces into a single line,
plus changes from function_declaration rule which tends
to avoid more whitespaces.

The change has a slight impact on phpstan, we
regenerate baseline.

To reduce backport headaches, this change is backported
to v12 and v11.

> composer req --dev friendsofphp/php-cs-fixer:^3.35.1
> Build/Scripts/runTests.sh -s cgl
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1124

Show 1104 more files

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/23/23, 22:35

  2. core-ci voted on patch set 1 V -1 10/23/23, 22:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48098

  3. Jasmina Ließmann voted on patch set 1 V +1 CR +1 10/23/23, 22:53

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 10/23/23, 23:04

  5. core-ci voted on patch set 2 V +1 10/23/23, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48103

  6. Jasmina Ließmann voted on patch set 2 V +1 CR +1 10/23/23, 23:21

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/23/23, 23:41

  8. Christian Kuhn merged patch set 3 10/23/23, 23:41