81532[FEATURE] Auto create DB fields from TCA for type "number"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 22
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php3+61 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/ext_tables.sql+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+230 −0
- typo3/sysext/core/ext_tables.sql+0 −5
- typo3/sysext/extensionmanager/ext_tables.sql+0 −3
- typo3/sysext/filemetadata/ext_tables.sql+0 −3
- typo3/sysext/frontend/ext_tables.sql+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/irre-records.xml+9 −9
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-complex.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+7 −7
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-flexform-softrefs.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+7 −7
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+7 −7
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-softrefs.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent.xml+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/irre-records.xml+9 −9
Review log 2635
Show 610 earlier messages
-
Anja Leichsenring uploaded patch set 1 10/24/23, 04:03
-
core-ci voted on patch set 1 V -1 10/24/23, 04:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48107
-
Anja Leichsenring uploaded patch set 2
V -110/24/23, 04:41 -
core-ci voted on patch set 2 V -1 10/24/23, 04:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48109
-
Anja Leichsenring uploaded patch set 3
V -110/24/23, 05:04 -
core-ci voted on patch set 3 V -1 10/24/23, 05:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48110
-
Anja Leichsenring uploaded patch set 4
V -110/24/23, 05:35 -
core-ci voted on patch set 4 V -1 10/24/23, 05:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48113
-
Oliver Klee commented on patch set 4 10/24/23, 11:28
-
Anja Leichsenring uploaded patch set 5
V -110/24/23, 12:06
-
Anja Leichsenring commented on patch set 5 10/24/23, 12:09
DefaultTcaSchema.php:970Replyif so, we need to do that for all the file, I copied that particular snippet. Would therefor say we tackle it in a dedicated patch. -
Oliver Klee commented on patch set 5 10/24/23, 12:09
DefaultTcaSchema.php:970ReplyAck -
core-ci voted on patch set 5 V -1 10/24/23, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48124
-
Garvin Hicking commented on patch set 5 10/24/23, 13:28
(just to note this here:) SQLite currently chokes on this via PDO; numbers are converted/mapped to (rounded) floats and thus insertion (and later on retrievals in tests) mismatches: 100.00 -> 100 100.0 -> 100 100.10 -> 100.1 100.99 -> 100.99 -
Anja Leichsenring uploaded patch set 6
V -110/25/23, 17:17 -
core-ci voted on patch set 6 V +1 10/25/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48191
-
Oliver Klee voted on patch set 6 V +1 10/25/23, 17:29
-
Garvin Hicking commented on patch set 6 CR +1 10/25/23, 19:23
Reply
DoneLooking good; maybe add a "todo" optimization pointer to move the $connection variable outside the inner loops, just when $tableName gets set, so it'll only be performed once per table. (Setting precision and scale via TCA as a follow-up, maybe integrate that in the todo pointer?) -
Stefan Bürk commented on patch set 6 CR -1 10/26/23, 07:27
on it ... -
Stefan Bürk uploaded patch set 7
CR +1V +110/26/23, 09:20 -
Garvin Hicking commented on patch set 7 V +1 CR +1 10/26/23, 09:26
Nice, seems to work in my test. Thanks for the doc pointers here! -
core-ci voted on patch set 7 V -1 10/26/23, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48216
-
Stefan Bürk uploaded patch set 8
CR +1V +110/26/23, 10:32 -
core-ci voted on patch set 8 V +1 10/26/23, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48220
-
Garvin Hicking voted on patch set 8 V +1 CR +1 10/26/23, 10:43
-
Stefan Bürk voted on patch set 8 V +1 CR +1 10/26/23, 10:50
-
Christian Kuhn commented on patch set 8 CR -1 10/26/23, 11:09
on it. -
Christian Kuhn uploaded patch set 9
CR +1V +110/26/23, 11:54 -
Christian Kuhn voted on patch set 9 V +1 CR +1 10/26/23, 11:54
-
Garvin Hicking voted on patch set 9 V +1 CR +1 10/26/23, 11:55
-
Stefan Bürk voted on patch set 9 V +1 CR +1 10/26/23, 11:58
-
core-ci voted on patch set 9 V +1 10/26/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48231
-
Nikita Hovratov voted on patch set 9 V +1 CR +1 10/26/23, 12:15
-
Christian Kuhn voted on patch set 9 V +2 CR +2 10/26/23, 12:17
-
Christian Kuhn merged patch set 10 10/26/23, 12:17
DefaultTcaSchema.php:970