Review main Merged

81534[TASK] Pin to PER Coding Style v1.0

Benjamin Franzke CR +2 V +2 Easy +4 −1 updated 10/24/23, 15:31

Commit message

PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27
in order to implement the new rules that are defined in
PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0
although the current set of rules are not implemented yet. [2]
There is only one rule (single_line_empty_body) that is done by now
and more will follow, so we rather pin to PER-CS1.0 for now (and
enable single_line_empty_body which we already migrated to) in
order to prevent having coding style changes with every
php-cs-fixer raise. We rather wait until the 2.0 preset has been
finished and is on par with the upstream php-fig definitions and
then switch with one change.

[1] https://www.php-fig.org/per/coding-style/
[2] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7247

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 10/24/23, 08:22

  2. core-ci voted on patch set 1 V +1 10/24/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48117

  3. Benjamin Franzke uploaded patch set 2 V +1 10/24/23, 08:35

  4. core-ci voted on patch set 2 V +1 10/24/23, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48118

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/24/23, 09:55

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/24/23, 09:55

  7. Benjamin Franzke commented on patch set 2 10/24/23, 10:23

    Will wait a bit until I merge, in case there are different opinions in the merger team.
  8. Andreas Kienast voted on patch set 2 CR +1 10/24/23, 11:28

  9. Benni Mack voted on patch set 2 V +1 CR +1 10/24/23, 15:02

  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/24/23, 15:15

  11. Benjamin Franzke merged patch set 3 10/24/23, 15:31