Review 12.4 Merged

81538[BUGFIX] Ensure CKEditor5 removePlugins is always a list

Benjamin Franzke CR +2 V +2 Easy +50 −0 updated 10/25/23, 14:27

Commit message

And therefore maps into a JSON array instead of an object,
preventing errors when CKEditor5 operated on the resulting
confguration.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 69

  1. Benjamin Franzke uploaded patch set 1 10/24/23, 14:57

  2. core-ci voted on patch set 1 V +1 10/24/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48129

  3. Benjamin Franzke uploaded patch set 2 V +1 10/24/23, 20:35

  4. core-ci voted on patch set 2 V -1 10/24/23, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48139

  5. Benjamin Franzke rebased onto patch set 3 V -1 10/25/23, 08:13

  6. core-ci voted on patch set 3 V +1 10/25/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48151

  7. Jasmina Ließmann commented on patch set 3 V +1 CR +1 10/25/23, 08:23

    This change is ready for review.
  8. Benjamin Franzke voted on patch set 3 V +2 CR +2 10/25/23, 14:27

  9. Benjamin Franzke merged patch set 4 10/25/23, 14:27