Review main Merged

81541[TASK] Fix php-cs-fixer config

Benjamin Franzke CR +2 V +2 Easy +7 −0 updated 10/25/23, 08:12

Commit message

Enable all current PER-CS2.0 rules in order to reflect our current
state of coding style. This was missed in #102240 because pre merge
didn't perform a full CGL run when @PER was switched to @PER-CS1.0.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Benjamin Franzke uploaded patch set 1 10/25/23, 04:37

  2. core-ci voted on patch set 1 V +1 10/25/23, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48145

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 10/25/23, 06:58

    Looks good on a local run.
  4. Benjamin Franzke rebased onto patch set 2 CR +1 V +1 10/25/23, 07:15

  5. core-ci voted on patch set 1 V -1 10/25/23, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48147

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 10/25/23, 07:16

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 10/25/23, 07:23

  8. core-ci voted on patch set 2 V +1 10/25/23, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48148

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 10/25/23, 07:47

  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/25/23, 08:11

  11. Benjamin Franzke merged patch set 3 10/25/23, 08:12