Review main Merged

81543[TASK] Clean up class ReferenceIndex

Christian Kuhn CR +2 V +2 Expert +730 −856 updated 10/25/23, 17:11

Commit message

A rewrite of the internal handling:

* The class is now practically a stateless service,
  the two left over properties are 'stable' until
  TCA changes within an instance usage, which is not
  the case in current usages.
* Extraction of setReferenceValue() and it's detail
  methods to CLI command 'cleanup:missingrelations'.
  That command needs an overhaul with another patch,
  but it's not more broken than before.
* Public methods at the start of the file.
* Clean method signature types.
* Disentanglement of code details, removing various
  detail methods to simplify reading. A method with
  eleven arguments has been inlined.
* Happy phpstan along the way.

The entire thing should be much easier to grasp and
follow now. Note getRelations() still returns a rather
opaque array of weird entries which can't be resolved
without additionally touching MissingRelationsCommand
and ext:impexp. This should be streamlined with
further patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1728

Show 23 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/25/23, 09:55

  2. core-ci voted on patch set 1 V +1 10/25/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48154

  3. Christian Kuhn uploaded patch set 2 V +1 10/25/23, 10:29

  1. core-ci voted on patch set 2 V +1 10/25/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48156

  2. Christian Kuhn uploaded patch set 3 V +1 10/25/23, 10:58

  3. Christian Kuhn uploaded patch set 4 10/25/23, 11:02

  4. core-ci voted on patch set 3 V +1 10/25/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48157

  5. core-ci voted on patch set 4 V +1 10/25/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48158

  6. Christian Kuhn uploaded patch set 5 V +1 10/25/23, 12:25

  7. core-ci voted on patch set 5 V -1 10/25/23, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48160

  8. Christian Kuhn uploaded patch set 6 V -1 10/25/23, 12:46

  9. core-ci voted on patch set 6 V +1 10/25/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48161

  10. Christian Kuhn uploaded patch set 7 V +1 10/25/23, 14:12

  11. core-ci voted on patch set 7 V +1 10/25/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48171

  12. Christian Kuhn uploaded patch set 8 V +1 10/25/23, 14:50

  13. core-ci voted on patch set 8 V +1 10/25/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48175

  14. Christian Kuhn uploaded patch set 9 V +1 10/25/23, 15:00

  15. core-ci voted on patch set 9 V +1 10/25/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48176

  16. Christian Kuhn updated the commit message in patch set 10 V +1 10/25/23, 15:26

  17. Christian Kuhn updated the commit message in patch set 11 10/25/23, 15:27

  18. core-ci voted on patch set 10 V +1 10/25/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48181

  19. core-ci voted on patch set 11 V +1 10/25/23, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48182

  20. Stefan Bürk voted on patch set 11 CR +1 10/25/23, 15:54

  21. Stefan Bürk voted on patch set 11 V +1 10/25/23, 16:12

  22. Nikita Hovratov voted on patch set 11 V +1 CR +1 10/25/23, 16:45

  23. Anja Leichsenring voted on patch set 11 V +1 CR +1 10/25/23, 17:10

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 10/25/23, 17:11

  25. Christian Kuhn merged patch set 12 10/25/23, 17:11