81550[BUGFIX] Handle `null` values in input transformation in AJAX requests
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Francois Suter +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Francois Suter +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 79
-
Andreas Kienast uploaded patch set 1 10/25/23, 15:05
-
Andreas Kienast uploaded patch set 2 10/25/23, 15:07
-
core-ci voted on patch set 1 V -1 10/25/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48177
-
core-ci voted on patch set 2 V +1 10/25/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48178
-
Andreas Kienast commented on patch set 2 10/25/23, 15:16
Can be tested altogether with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81551Note: on my machine, this patch does not entirely fix the suggest wizard, as I get the following error on main only: ``` Too few arguments to function TYPO3\CMS\Backend\Controller\Wizard\SuggestWizardController::__construct(), 0 passed in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2798 and exactly 1 expected ``` One possible fix is to add the `#[Controller]` controller attribute, but I do no understand why it's not necessary in v12, yet. -
Stefan Bürk voted on patch set 2 V +1 CR +1 10/25/23, 15:24
-
Francois Suter voted on patch set 2 V +1 CR +1 10/25/23, 15:41
-
Andreas Kienast voted on patch set 2 V +2 CR +2 10/25/23, 15:45
-
Andreas Kienast merged patch set 3 10/25/23, 15:54