Review main Merged

81550[BUGFIX] Handle `null` values in input transformation in AJAX requests

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 10/25/23, 15:54

Commit message

The module `@typo3/core/ajax/input-transformer` is used to automatically
prepare payload to be sent via AJAX. One sub-routine converts nested
objects into a flat list recursively. However, the check for objects was
not sufficient as, in JavaScript, `null` is also of type `object`. This
patch hardens the check to consider non-null values only.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Francois Suter +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Francois Suter +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 10/25/23, 15:05

  2. Andreas Kienast uploaded patch set 2 10/25/23, 15:07

  3. core-ci voted on patch set 1 V -1 10/25/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48177

  4. core-ci voted on patch set 2 V +1 10/25/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48178

  5. Andreas Kienast commented on patch set 2 10/25/23, 15:16

    Note: on my machine, this patch does not entirely fix the suggest wizard, as I get the following error on main only: ``` Too few arguments to function TYPO3\CMS\Backend\Controller\Wizard\SuggestWizardController::__construct(), 0 passed in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2798 and exactly 1 expected ``` One possible fix is to add the `#[Controller]` controller attribute, but I do no understand why it's not necessary in v12, yet.
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/25/23, 15:24

  7. Francois Suter voted on patch set 2 V +1 CR +1 10/25/23, 15:41

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 10/25/23, 15:45

  9. Andreas Kienast merged patch set 3 10/25/23, 15:54