Review 12.4 Merged

81559[TASK] Introduce Symfony attribute based registration of CLI commands

Stefan Bürk CR +2 V +2 Normal +80 −0 updated 10/26/23, 21:47

Commit message

CLI commands had to be registered in the extensions `Services.yaml`
file with the `console.command` tag. This change enables automatic
cli command registration with the tag `console.command` by using
the existing `\Symfony\Component\Console\Attribute\AsCommand`
symfony PHP attribute. Thus providing an additional and simpler
way, without deprecating or enforcing to change already existing
registrations.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Stefan Bürk commented on patch set 1 10/26/23, 21:14

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Configuration/Services.php
  2. Stefan Bürk uploaded patch set 2 10/26/23, 21:22

  3. Stefan Bürk commented on patch set 2 10/26/23, 21:22

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 10/26/23, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48263

  5. Stefan Bürk updated the commit message in patch set 3 10/26/23, 21:27

  6. core-ci voted on patch set 2 V +1 10/26/23, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48264

  7. core-ci voted on patch set 3 V +1 10/26/23, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48267

  8. Stefan Bürk voted on patch set 3 V +2 CR +2 10/26/23, 21:47

  9. Stefan Bürk merged patch set 4 10/26/23, 21:47