Review main Merged

81573[BUGFIX] Make ContentRenderer catch more errors

Sascha Egerer CR +2 V +2 Easy +6 −1 updated 06/19/24, 21:06

Commit message

The ContentObjectRenderer catches \Exception's
that occur during the rendering of a content element.
However, since PHP 7, there is a \TypeError exception that
occurs, for example, if the given type does not match the
declared type.
Because \TypeError is not a subtype of \Exception, these
errors are not caught in the production context, and instead
of not rendering a single content element, the whole page
is not rendered.
Since all types of \Throwable are essentially errors that
will interrupt the rendering process, the catch block must
accommodate all of these, not just implementations of \Exception.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Sascha Egerer uploaded patch set 1 10/25/23, 20:02

  2. core-ci voted on patch set 1 V -1 10/25/23, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48199

  3. Sascha Egerer uploaded patch set 2 V -1 10/26/23, 06:43

  4. core-ci voted on patch set 2 V -1 10/26/23, 06:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48209

  5. Sascha Egerer uploaded patch set 3 V -1 10/26/23, 19:09

  6. core-ci voted on patch set 3 V +1 10/26/23, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48257

  7. Benni Mack voted on patch set 3 CR +1 10/27/23, 09:52

  8. Oliver Klee voted on patch set 3 CR +1 10/27/23, 10:57

  9. Stefan Bürk voted on patch set 3 CR +1 11/06/23, 16:31

  10. Simon Schaufelberger voted on patch set 3 V +1 05/14/24, 08:59

  11. Simon Schaufelberger wrote 05/14/24, 09:00

    Removed reviewer Simon Schaufelberger with the following votes: * Verified+1 by Simon Schaufelberger
  12. Georg Ringer voted on patch set 3 CR +1 V +1 06/18/24, 19:59

  13. Benni Mack voted on patch set 3 CR +2 V +2 06/19/24, 21:06

  14. Benni Mack merged patch set 4 06/19/24, 21:06