Review main Merged

81576[TASK] Return __toString value from objects in DataMapper::getPlainValue

Soren Malling CR +2 V +2 Easy +1 −1 updated 10/26/23, 13:07

Commit message

See if a object is a instance of \Stringable aswell as a TypeInterface.

TypeInterface implements the __toString method but objects coming
from extension can rely on either implements \Stringable or
have the __toString method

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Soren Malling uploaded patch set 1 10/26/23, 09:55

  2. core-ci voted on patch set 1 V +1 10/26/23, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48218

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/26/23, 10:45

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/26/23, 10:56

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/23, 11:34

  6. Oliver Klee voted on patch set 1 V +1 CR +1 10/26/23, 12:23

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/23, 13:07

  8. Christian Kuhn merged patch set 2 10/26/23, 13:07