Review 12.4 Merged

81580[TASK] Use ConsumableNonce instead of blunt Nonce in CSP context

Oliver Hader CR +2 V +2 Normal +125 −93 updated 10/26/23, 16:09

Commit message

To identify whether a nonce values was actually used (consumed),
`ConsumableNonce` instances are used, instead of `Nonce` objects.
The new `ConsumableNonce` inherits from `ConsumableString`.

As a result, the `<f:security.nonce>` view helper would increase
the consumption counter. This is important for additional cache
handling in the frontend rendering context.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 57

  1. Oliver Hader uploaded patch set 1 10/26/23, 14:51

  2. core-ci voted on patch set 1 V -1 10/26/23, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48239

  3. Oliver Hader uploaded patch set 2 V -1 10/26/23, 15:58

  4. core-ci voted on patch set 2 V +1 10/26/23, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48248

  5. Oliver Hader voted on patch set 2 CR +2 10/26/23, 16:09

  6. Oliver Hader voted on patch set 2 V +2 10/26/23, 16:09

  7. Oliver Hader merged patch set 3 10/26/23, 16:09