81588[TASK] Remove usage of deprecated `doctrine/event-manager`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 57
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+3 −3
- typo3/sysext/core/Classes/Database/Driver/PDOSqlite/Driver.php+4 −4
- typo3/sysext/core/Classes/Database/Driver/CustomPlatformDriverDecorator.phpnew+119 −0
- typo3/sysext/core/Classes/Database/Middleware/CustomPlatformDriverMiddleware.phpnew+33 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1027Platform.phpnew+63 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1043Platform.phpnew+64 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1052Platform.phpnew+62 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDBPlatform.phpnew+64 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL57Platform.phpnew+67 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL80Platform.phpnew+62 −0
- typo3/sysext/core/Classes/Database/Platform/MySQLCompatibleAlterTablePlatformAwareTrait.phpnew+59 −0
- typo3/sysext/core/Classes/Database/Platform/MySQLPlatform.phpnew+65 −0
- typo3/sysext/core/Classes/Database/Platform/OraclePlatform.phpnew+40 −0
- typo3/sysext/core/Classes/Database/Platform/PlatformInformation.php+19 −12
- typo3/sysext/core/Classes/Database/Platform/PostgreSQL94Platform.phpnew+41 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQL100Platform.phpnew+42 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQLPlatform.phpnew+40 −0
- typo3/sysext/core/Classes/Database/Platform/SQLitePlatform.phpnew+40 −0
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+3 −3
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+9 −8
Show 37 more files
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaAlterTableListener.phpdeleted+0 −68
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaIndexDefinitionListener.phpdeleted+0 −134
- typo3/sysext/core/Classes/Database/Schema/Exception/DefaultTcaSchemaTablePositionException.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Exception/StatementException.php+3 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CoreSchemaManagerFactory.phpnew+63 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.phprenamed+19 −32
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomPortableTableIndexesListTrait.phpnew+150 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/MySQLSchemaManager.phpnew+99 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/OracleSchemaManager.phpnew+68 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/PostgreSQLSchemaManager.phpnew+67 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/SQLiteSchemaManager.phpnew+68 −0
- typo3/sysext/core/Classes/Database/Schema/Types/DateTimeType.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/Types/DateType.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/Types/EnumType.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/Types/SetType.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/Types/TimeType.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/Comparator.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+20 −14
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/SqlReader.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/TableDiff.php+1 −1
- typo3/sysext/core/Classes/Database/ConnectionPool.php+29 −31
- typo3/sysext/core/Documentation/Changelog/13.0/Important-102402-ExtendedDoctrineDBALPlatformClasses.rstnew+67 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Database/Platform/PlatformInformationTest.php+14 −12
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+30 −13
- typo3/sysext/core/Tests/Unit/Database/Schema/EventListener/SchemaColumnDefinitionListenerTest.phpdeleted+0 −116
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureMySQLSchemaManager.phpnew+48 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureOracleSchemaManager.phpnew+48 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixturePostgreSQLSchemaManager.phpnew+48 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureSQLiteSchemaManager.phpnew+48 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/MySQLSchemaManagerTest.phpnew+151 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/OracleSchemaManagerTest.phpnew+113 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/PostgreSQLSchemaManagerTest.phpnew+133 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/SQLiteSchemaManagerTest.phpnew+113 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+3 −3
Review log 2336
Show 611 earlier messages
-
Stefan Bürk uploaded patch set 1 10/26/23, 16:38
-
core-ci voted on patch set 1 V -1 10/26/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48255
-
Stefan Bürk uploaded patch set 2
V -110/26/23, 16:55 -
core-ci voted on patch set 2 V -1 10/26/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48256
-
Stefan Bürk rebased onto patch set 3
V -111/06/23, 09:32 -
core-ci voted on patch set 3 V -1 11/06/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48625
-
Stefan Bürk uploaded patch set 4
V -111/07/23, 11:38 -
core-ci voted on patch set 4 V -1 11/07/23, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48686
-
Stefan Bürk uploaded patch set 5
V -111/16/23, 12:48 -
core-ci voted on patch set 5 V +1 11/16/23, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49023
-
Stefan Bürk rebased onto patch set 6
V +111/17/23, 06:47
-
core-ci voted on patch set 6 V +1 11/17/23, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49052
-
Stefan Bürk uploaded patch set 7
V +111/17/23, 16:10 -
core-ci voted on patch set 7 V +1 11/17/23, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49070
-
Stefan Bürk wrote 11/19/23, 16:18
Topic set to doctrine-dbal -
Stefan Bürk uploaded patch set 8
V +111/19/23, 18:17 -
core-ci voted on patch set 8 V +1 11/19/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49101
-
Stefan Bürk rebased onto patch set 9 11/19/23, 18:42
Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE") -
Stefan Bürk uploaded patch set 10 11/19/23, 18:47
Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 9 V +1 11/19/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49102
-
core-ci voted on patch set 10 V +1 11/19/23, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49103
-
Benni Mack commented on patch set 11
V +111/19/23, 22:15Published edit on patch set 10. -
Benni Mack voted on patch set 11 V +1 CR +1 11/19/23, 22:15
-
core-ci voted on patch set 11 V +1 11/19/23, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49112
-
Oliver Klee voted on patch set 11 CR +1 11/20/23, 07:07
-
Benni Mack commented on patch set 11 V 0 CR 0 11/20/23, 11:39
maybe we could use the Middleware approach instead of extending all platforms to have a separate helper class to identify the platform name and features? -
Stefan Bürk commented on patch set 11 11/20/23, 11:58
Reply
Sadly, that's not possible. doctrine middleware can only be used to decorate `driver`, `connection`, `statement` and `result`. And still, extending all platform classes would be needed needed to integrate the needed changes for the schema definition and alter stuff. Driver are returning the platform created with "new", eventually based on version aware things. That changes slightly with doctrine/dbal 4 - but still this is the only way to replace the deprecated events. See: https://github.com/doctrine/dbal/issues/5784 -
Stefan Bürk rebased onto patch set 12
CR +1V +111/20/23, 12:41 -
Christian Kuhn uploaded patch set 13 11/20/23, 12:46
-
core-ci voted on patch set 12 V +1 11/20/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49127
-
core-ci voted on patch set 13 V +1 11/20/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49130
-
Oliver Klee voted on patch set 13 V +1 11/20/23, 13:16
-
Christian Kuhn voted on patch set 13 V +1 CR +1 11/20/23, 14:04
-
Garvin Hicking voted on patch set 13 V +1 CR +1 11/20/23, 14:18
-
Stefan Bürk voted on patch set 13 V +2 CR +2 11/20/23, 14:24
-
Stefan Bürk merged patch set 14 11/20/23, 14:24