Review main Merged

81590[TASK] Avoid calling migrateFlexFormTcaRecursive() twice

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 10/27/23, 09:39

Commit message

With #99756, migrating DS in FlexForms has (indirectly)
been added to parseDataStructureByIdentifier(), so any
DS is "clean" afterwards. FormEngine related ajax
controllers trigger this when a data structure
identifier is supplied.

Calling this a second time in FormEngine TcaFlexPrepare
does not make sense and is removed now.

This allows us to protect that internal method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/26/23, 22:08

  2. Christian Kuhn updated the commit message in patch set 2 10/26/23, 22:11

  3. core-ci voted on patch set 2 V +1 10/26/23, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48270

  4. core-ci voted on patch set 1 V +1 10/26/23, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48269

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/27/23, 07:27

  6. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/27/23, 08:32

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/27/23, 09:38

  8. Christian Kuhn merged patch set 3 10/27/23, 09:39