Review main Merged

81591[TASK] Extract FlexForm TCA migration & preparation

Christian Kuhn CR +2 V +2 Easy +12 −0 updated 10/27/23, 10:37

Commit message

Having the TCA migration & preparation of single
FlexForm fields within resolveFileDirectives() which
is supposed to only resolve sheet sub files is
confusing. It should be an own method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/23, 22:26

  2. core-ci voted on patch set 1 V +1 10/26/23, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48271

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/27/23, 09:01

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 10/27/23, 09:58

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/27/23, 10:37

  6. Christian Kuhn merged patch set 2 10/27/23, 10:37