Review main Abandoned

81595[BUGFIX] Correct tree.pagelayout condition evaluation on page level 1

Stig Nørgaard Færch CR 0 V 0 Easy +1 −0 updated 02/06/24, 15:01

Commit message

In the context of TypoScript the ContentObjectRenderer and the
ConditionMatcher make use of the getLayoutForPage method to find the
correct layout of the current page. Unfortunately, regarding page level 1,
this only works correctly for the ContentObjectRenderer (type
getText:pagelayout). In the context of the ConditionMatcher, the layout
will not be found from the root level field backend_layout_next_level.

In this method, the rootline is used to determin the pages to find the
backend_layout_next_level from, starting with the closest parent page, but
not the current page itself.
This fix ensures that the current page will be removed from the rootline,
and not the root page.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 69

  1. Stig Nørgaard Færch uploaded patch set 1 10/27/23, 11:28

  2. Stig Nørgaard Færch rebased onto patch set 2 10/27/23, 11:30

  3. Stig Nørgaard Færch rebased onto patch set 3 10/27/23, 11:31

  4. core-ci voted on patch set 1 V -1 10/27/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48285

  5. core-ci voted on patch set 2 V -1 10/27/23, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48286

  6. core-ci voted on patch set 3 V -1 10/27/23, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48287

  7. Nikita Hovratov commented on patch set 3 01/28/24, 00:57

    Hi, seems like this patch is red and stale. In the meantime we got another patch, which tries to solve this differently. If it's alright I'll abandon this patch. Thanks for your contribition anyway!
  8. Nikita Hovratov abandoned the change 01/28/24, 00:57

    New patch with another approach is there
  9. Stephan Großberndt commented on patch set 3 02/06/24, 15:01