Review main Merged

81597[BUGFIX] Allow custom AbortSignal to be passed to AjaxRequest methods

Benjamin Franzke CR +2 V +2 Easy +22 −2 updated 10/31/23, 16:24

Commit message

AjaxRequest uses an own AbortController instance in order to provide
the abort() method. It therefore passes the corresponding AbortSignal
instance as a forced option to fetch(), and overwrites any custom
signal that is passed as request options.

In order to support custom AbortSignal's passed as fetch option,
the abort event of the custom AbortSignal is now forwarded to the
internal AbortController instance.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Benjamin Franzke uploaded patch set 1 10/27/23, 13:52

  2. core-ci voted on patch set 1 V +1 10/27/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48293

  3. Benjamin Franzke uploaded patch set 2 V +1 10/30/23, 11:17

  4. core-ci voted on patch set 2 V +1 10/30/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48351

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 10/30/23, 15:08

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/31/23, 15:28

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/31/23, 16:24

  8. Benjamin Franzke merged patch set 3 10/31/23, 16:24