81598[TASK] Migrate icon-element to @lit/task
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/element/icon-element.ts+21 −13
- Build/Sources/TypeScript/backend/tests/icons-test.ts+0 −16
- Build/Sources/TypeScript/backend/icons.ts6+30 −77
- Build/Sources/TypeScript/core/cache/dedupe-async-task.tsnew+95 −0
- Build/Sources/TypeScript/core/tests/cache/dedupe-async-task-test.tsnew+152 −0
- Build/Gruntfile.js+1 −0
- Build/package-lock.json+9 −0
- Build/package.json+1 −0
- Build/web-test-runner.config.mjs+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+9 −5
- typo3/sysext/backend/Resources/Public/JavaScript/icons.js+2 −2
- typo3/sysext/core/Configuration/JavaScriptModules.php+2 −0
- typo3/sysext/core/Resources/Public/JavaScript/cache/dedupe-async-task.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/task/deep-equals.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/task/index.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/task/task.jsnew+6 −0
Review log 1421
-
Benjamin Franzke uploaded patch set 1 10/27/23, 13:52
-
core-ci voted on patch set 1 V -1 10/27/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48294
-
Benjamin Franzke uploaded patch set 2
V -110/27/23, 14:14 -
core-ci voted on patch set 2 V +1 10/27/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48296
-
Benjamin Franzke uploaded patch set 3
V +111/02/23, 19:29 -
Benjamin Franzke uploaded patch set 4 11/02/23, 19:30
-
core-ci voted on patch set 3 V +1 11/02/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48514
-
core-ci voted on patch set 4 V +1 11/02/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48515
-
Benjamin Franzke uploaded patch set 5
V +111/03/23, 08:01 -
core-ci voted on patch set 5 V +1 11/03/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48530
-
Andreas Kienast commented on patch set 5 V +1 11/03/23, 11:54
icons.ts:215Local variable promise is redundant -
Benjamin Franzke uploaded patch set 6
V +111/03/23, 12:07 -
Benjamin Franzke commented on patch set 6 11/03/23, 12:07
icons.ts:158ReplyDoneicons.ts:215ReplyDone -
Andreas Kienast commented on patch set 6 11/03/23, 12:12
icons.ts:189``` TS80006: This may be converted to an async function. ``` Not sure however what's the impact if it's done. -
core-ci voted on patch set 6 V +1 11/03/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48539
-
Benjamin Franzke uploaded patch set 7
V +111/03/23, 12:19 -
core-ci voted on patch set 7 V +1 11/03/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48542
-
Andreas Kienast commented on patch set 7 V +1 CR +1 11/03/23, 12:27
icons.ts:189ReplyDone -
Benni Mack voted on patch set 7 V +1 CR +1 11/03/23, 21:29
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 11/04/23, 10:00
-
Benjamin Franzke merged patch set 8 11/04/23, 10:44
icons.ts:158