Review main Merged

81598[TASK] Migrate icon-element to @lit/task

Benjamin Franzke CR +2 V +2 Hard +350 −113 updated 11/04/23, 10:44

Commit message

@lit/task graduated from a 2-year @lit-labs phase, to an officially
supported helper library for lit elements. We want to start using it
as it embraces a tri-state model for async operations:

  * pending
  * complete
  * error

…which is important in order to always handle error cases instead of
silently ignoring them. Also existing or currently running requests are
aborted and/or ignored when a newer state has already been activated.

The icon-library deduplication caching strategy is refactored into a
reusable helper instance that is a bit more generic and allows to
abort (ref counted across duplicate requests) async operations.

Commands executed:

  npm install --save @lit/task
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1421

  1. Benjamin Franzke uploaded patch set 1 10/27/23, 13:52

  2. core-ci voted on patch set 1 V -1 10/27/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48294

  3. Benjamin Franzke uploaded patch set 2 V -1 10/27/23, 14:14

  4. core-ci voted on patch set 2 V +1 10/27/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48296

  5. Benjamin Franzke uploaded patch set 3 V +1 11/02/23, 19:29

  6. Benjamin Franzke uploaded patch set 4 11/02/23, 19:30

  7. core-ci voted on patch set 3 V +1 11/02/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48514

  8. core-ci voted on patch set 4 V +1 11/02/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48515

  9. Benjamin Franzke uploaded patch set 5 V +1 11/03/23, 08:01

  10. core-ci voted on patch set 5 V +1 11/03/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48530

  11. Andreas Kienast commented on patch set 5 V +1 11/03/23, 11:54

    icons.ts:158

    PhpStorm annotates: ``` Parameter signal is not described in JSDoc ``` I think, we can drop JSDoc here anyway.

    icons.ts:215

    Local variable promise is redundant
  12. Benjamin Franzke uploaded patch set 6 V +1 11/03/23, 12:07

  13. Benjamin Franzke commented on patch set 6 11/03/23, 12:07

    icons.ts:158 Reply

    Done

    icons.ts:215 Reply

    Done
  14. Andreas Kienast commented on patch set 6 11/03/23, 12:12

    icons.ts:189

    ``` TS80006: This may be converted to an async function. ``` Not sure however what's the impact if it's done.
  15. core-ci voted on patch set 6 V +1 11/03/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48539

  16. Benjamin Franzke uploaded patch set 7 V +1 11/03/23, 12:19

  17. core-ci voted on patch set 7 V +1 11/03/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48542

  18. Andreas Kienast commented on patch set 7 V +1 CR +1 11/03/23, 12:27

    icons.ts:189 Reply

    Done
  19. Benni Mack voted on patch set 7 V +1 CR +1 11/03/23, 21:29

  20. Benjamin Franzke voted on patch set 7 V +2 CR +2 11/04/23, 10:00

  21. Benjamin Franzke merged patch set 8 11/04/23, 10:44