Review main Merged

81606[TASK] Use constructor property promotion in ext:install

Torben Hansen CR +2 V +2 Normal +47 −195 updated 10/30/23, 09:50

Commit message

Several classes in ext:install do not use constructor property
promotion. This change introduces constructor property promotion
where suitable.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 78

  1. Torben Hansen uploaded patch set 1 10/29/23, 05:44

  2. core-ci voted on patch set 1 V +1 10/29/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48334

  3. Oliver Klee commented on patch set 1 10/29/23, 09:23

    StatusMessage.php:32

    Can we also CPP this property (while keeping the PHPDoc type annotation)?
  4. Torben Hansen commented on patch set 1 10/29/23, 10:15

    StatusMessage.php:32 Reply

    No, PHP does not support CPP for variadic parameters.
  5. Oliver Klee commented on patch set 1 V +1 CR +1 10/29/23, 10:20

    StatusMessage.php:32 Reply

    Ack. I just learned something new - thanks!
  6. Simon Schaufelberger voted on patch set 1 V +1 CR +1 10/29/23, 20:57

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 10/30/23, 09:50

  8. Benjamin Franzke merged patch set 2 10/30/23, 09:50