81606[TASK] Use constructor property promotion in ext:install
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/install/Classes/Controller/IconController.php+4 −15
- typo3/sysext/install/Classes/CoreVersion/CoreRelease.php+7 −14
- typo3/sysext/install/Classes/CoreVersion/MaintenanceWindow.php+4 −8
- typo3/sysext/install/Classes/CoreVersion/MajorRelease.php+6 −12
- typo3/sysext/install/Classes/Service/ClearCacheService.php+3 −16
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+1 −7
- typo3/sysext/install/Classes/Service/LanguagePackService.php+3 −21
- typo3/sysext/install/Classes/Service/SilentTemplateFileUpgradeService.php+1 −6
- typo3/sysext/install/Classes/Service/Typo3tempFileService.php+4 −8
- typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/StatusMessage.php3+1 −7
- typo3/sysext/install/Classes/Updates/Confirmation.php+7 −44
- typo3/sysext/install/Classes/Updates/ExtensionModel.php+6 −37
Review log 78
-
Torben Hansen uploaded patch set 1 10/29/23, 05:44
-
core-ci voted on patch set 1 V +1 10/29/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48334
-
Oliver Klee commented on patch set 1 10/29/23, 09:23
-
Torben Hansen commented on patch set 1 10/29/23, 10:15
StatusMessage.php:32ReplyNo, PHP does not support CPP for variadic parameters. -
Oliver Klee commented on patch set 1 V +1 CR +1 10/29/23, 10:20
StatusMessage.php:32ReplyAck. I just learned something new - thanks! -
Simon Schaufelberger voted on patch set 1 V +1 CR +1 10/29/23, 20:57
-
Benjamin Franzke voted on patch set 1 V +2 CR +2 10/30/23, 09:50
-
Benjamin Franzke merged patch set 2 10/30/23, 09:50
StatusMessage.php:32