81618[!!!][TASK] Streamline File Processing API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 15
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Imaging/ImageDimension.php+3 −4
- typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.phpdeleted+0 −82
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php+37 −110
- typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php3+44 −21
- typo3/sysext/core/Classes/Resource/Processing/ImagePreviewTask.php+45 −37
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+2 −7
- typo3/sysext/core/Classes/Resource/Processing/TaskInterface.php+15 −39
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+5 −12
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+34 −93
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+1 −4
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102165-FileAbstractionLayerProcessingAPIsAndInterfaceChanged.rst4new+66 −0
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+2 −10
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1318
-
Benni Mack uploaded patch set 1 10/30/23, 20:57
-
core-ci voted on patch set 1 V -1 10/30/23, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48369
-
Benni Mack uploaded patch set 2
V -110/30/23, 21:34 -
core-ci voted on patch set 2 V -1 10/30/23, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48370
-
Benni Mack uploaded patch set 3
V -110/31/23, 11:14 -
core-ci voted on patch set 3 V -1 10/31/23, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48395
-
Benni Mack uploaded patch set 4
V -110/31/23, 11:31 -
core-ci voted on patch set 4 V +1 10/31/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48397
-
Andreas Kienast commented on patch set 4 10/31/23, 13:03
Breaking-102165-FileAbstractionLayerProcessingAPIsAndInterfaceChanged.rst:43```[...] the :php:`AbstractGraphicalTask` class, [...]```Breaking-102165-FileAbstractionLayerProcessingAPIsAndInterfaceChanged.rst:63``` :php:`AbstractTask` ``` -
Benni Mack commented on patch set 4 10/31/23, 13:07
ImageCropScaleMaskTask.php:58Replynot yet (in GraphicalFunctions). This will be a separate patch -
Benni Mack commented on patch set 5
V +110/31/23, 13:08Published edit on patch set 4. -
Benni Mack commented on patch set 5 10/31/23, 13:08
ImageCropScaleMaskTask.php:58ReplyDoneBreaking-102165-FileAbstractionLayerProcessingAPIsAndInterfaceChanged.rst:43ReplyDoneBreaking-102165-FileAbstractionLayerProcessingAPIsAndInterfaceChanged.rst:63ReplyDone -
Andreas Kienast voted on patch set 5 V +1 CR +1 10/31/23, 13:12
-
core-ci voted on patch set 5 V +1 10/31/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48405
-
Stefan Bürk voted on patch set 5 CR -1 11/02/23, 08:41
-
Stefan Bürk voted on patch set 5 V +1 CR +1 11/02/23, 09:23
-
Benni Mack voted on patch set 5 V +2 CR +2 11/02/23, 10:04
-
Benni Mack merged patch set 6 11/02/23, 10:04
ImageCropScaleMaskTask.php:58