81619[TASK] Allow creation of lossless webp images
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1518
-
Benni Mack uploaded patch set 1 10/30/23, 21:59
-
core-ci voted on patch set 1 V +1 10/30/23, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48371
-
Christian Kuhn voted on patch set 1 V +1 CR +1 10/31/23, 11:36
-
Andreas Kienast commented on patch set 1 10/31/23, 11:49
-
Andreas Kienast commented on patch set 1 10/31/23, 12:12
GifBuilder.php:183Also, why don't we use the constant `IMG_WEBP_LOSSLESS` directly? -
Benni Mack commented on patch set 1 10/31/23, 12:46
GifBuilder.php:182ReplyLOLGifBuilder.php:183ReplyMy PHPStorm said "please require php-gd for this" ;) -
Benni Mack commented on patch set 2
CR +1V +110/31/23, 12:47Published edit on patch set 1. -
Benni Mack commented on patch set 2 10/31/23, 12:47
GifBuilder.php:182ReplyDoneGifBuilder.php:183ReplyDone -
core-ci voted on patch set 2 V +1 10/31/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48402
-
Andreas Kienast updated the commit message in patch set 3
V +110/31/23, 13:04 -
Andreas Kienast voted on patch set 3 V +1 CR +1 10/31/23, 13:04
-
core-ci voted on patch set 3 V +1 10/31/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48404
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/31/23, 13:57
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/31/23, 15:23
-
Benni Mack commented on patch set 3 V +2 CR +2 10/31/23, 15:30
thank yoU! -
Benni Mack merged patch set 4 10/31/23, 15:30
-
Xavier Perseguers commented on patch set 4 10/31/23, 16:19
late replyFeature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:30"equivalent" is not a verb, this should read "is equivalent" -
Benni Mack commented on patch set 4 11/23/23, 10:28
Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:30ReplyDone
GifBuilder.php:182