Review main Merged

81619[TASK] Allow creation of lossless webp images

Benni Mack CR +2 V +2 Easy +27 −15 updated 11/23/23, 10:28

Commit message

Since PHP 8.1, GDImage can create lossless webp
images. However, in #102177 this wasn't checked
for properly.

This change adapts the RST and also fixes
some minor documentation parts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1518

  1. Benni Mack uploaded patch set 1 10/30/23, 21:59

  2. core-ci voted on patch set 1 V +1 10/30/23, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48371

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/31/23, 11:36

  4. Andreas Kienast commented on patch set 1 10/31/23, 11:49

    GifBuilder.php:182

    I wonder where this typo comes from.
  5. Andreas Kienast commented on patch set 1 10/31/23, 12:12

    GifBuilder.php:183

    Also, why don't we use the constant `IMG_WEBP_LOSSLESS` directly?
  6. Benni Mack commented on patch set 1 10/31/23, 12:46

    GifBuilder.php:182 Reply

    LOL

    GifBuilder.php:183 Reply

    My PHPStorm said "please require php-gd for this" ;)
  7. Benni Mack commented on patch set 2 CR +1 V +1 10/31/23, 12:47

    Published edit on patch set 1.
  8. Benni Mack commented on patch set 2 10/31/23, 12:47

    GifBuilder.php:182 Reply

    Done

    GifBuilder.php:183 Reply

    Done
  9. core-ci voted on patch set 2 V +1 10/31/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48402

  10. Andreas Kienast updated the commit message in patch set 3 V +1 10/31/23, 13:04

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 10/31/23, 13:04

  12. core-ci voted on patch set 3 V +1 10/31/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48404

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 10/31/23, 13:57

  14. Christian Kuhn voted on patch set 3 V +1 CR +1 10/31/23, 15:23

  15. Benni Mack commented on patch set 3 V +2 CR +2 10/31/23, 15:30

    thank yoU!
  16. Benni Mack merged patch set 4 10/31/23, 15:30

  17. Xavier Perseguers commented on patch set 4 10/31/23, 16:19

    late reply

    Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:30

    "equivalent" is not a verb, this should read "is equivalent"
  18. Benni Mack commented on patch set 4 11/23/23, 10:28

    Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst:30 Reply

    Done