81645[BUGFIX] Handle empty values with FormEngine radio fields
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsEmptyElementsCest.phpnew+154 −0
- typo3/sysext/core/Tests/Acceptance/Application/Page/PageModuleCest.php+17 −23
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+22 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select.php+1 −0
Review log 2539
Show 1014 earlier messages
-
Garvin Hicking uploaded patch set 1 11/02/23, 12:26
-
Garvin Hicking updated the commit message in patch set 2 11/02/23, 12:30
Change formatting of commit message -
core-ci voted on patch set 1 V +1 11/02/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48483
-
core-ci voted on patch set 2 V +1 11/02/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48484
-
Simon Schaufelberger commented on patch set 2 11/02/23, 14:03
possible -> probablyplease no test in the commit message. this belongs into the forge issue. please also create a test that covers this case. -
Simon Schaufelberger commented on patch set 2 11/02/23, 14:04
please rebase your patch and add test case to the styleguide extension -
Garvin Hicking commented on patch set 2 11/02/23, 17:43
Thanks for looking into it; gave some feedback, generally I'd love to hear feedback on whether this is regarded as a bug and we can continue with the approach.Reply
I will do so when this fix generally gets approval!Reply
AckReply
I will remove the test from the commit message at a later point, I found it easier to read it here in one go while this gets checked from others. However I'll also add it to the issue. How can I create a test for this, can you give me a examples or an outline? I don't really know how. Also, I would only put time and effort into this if the fix is generally accepted/agreed on. -
Garvin Hicking uploaded patch set 3
V +111/02/23, 19:07Added styleguide patch and shorten commit message -
Garvin Hicking commented on patch set 3 11/02/23, 19:09
Reply
Added the example to the styleguide extension, thanks!Reply
DoneReply
I shortened the commit message, moved the testing instructions to the ticket, thanks for the suggestion. :-) Also I addressed the "TODO" section about missing functional/acceptance tests for this. -
core-ci voted on patch set 3 V +1 11/02/23, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48512
-
Simon Schaufelberger commented on patch set 3 11/02/23, 19:40
Reply
The styleguide extension has a ton of tests, just include your test case into it. -
Garvin Hicking commented on patch set 3 11/03/23, 08:20
Reply
Could you point me to one you think is "close" to it? The styleguide extension has exactly one UnitTest for "Kauderwelschservice" only https://github.com/TYPO3/typo3/tree/main/typo3/sysext/styleguide/Tests/Unit/Service I would need something to test like: * Display a specific field in FormEngine (here: radio option with empty value) - Acceptance browser remote control? * "Save" a record - also Acceptance remote control? Subrequest? * Compare if the saved record holds the expected value - Is the above synchronous, so that I can check the record after the action is performed? I have never used the acceptance "browser remote control" tests yet and it would help me a lot of you could point me into a specific direction, thank you! -
Garvin Hicking updated the commit message in patch set 4
V +111/03/23, 09:57Update title to better reflect importance -
core-ci voted on patch set 4 V +1 11/03/23, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48532
-
Garvin Hicking uploaded patch set 5
V +111/08/23, 18:58Rebase and add stub acceptance test -
core-ci voted on patch set 5 V -1 11/08/23, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48729
-
Garvin Hicking uploaded patch set 6
V -111/08/23, 19:19Disable non working test for now -
core-ci voted on patch set 6 V +1 11/08/23, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48730
-
Garvin Hicking uploaded patch set 7
V +111/09/23, 18:10Work on acceptance test with radio -
core-ci voted on patch set 7 V +1 11/09/23, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48762
-
Garvin Hicking uploaded patch set 8
V +111/10/23, 10:49Add empty element check to acceptance test -
Garvin Hicking commented on patch set 8 11/10/23, 10:52
Reply
AckI've now added acceptance tests, and they are able to check this scenario. Without the patch to RadioElement applied, the test will fail because radio states are not retrievable. With it, the tests succeed. Would love some feedback on how/if to proceed with this :-)Reply
I've now added an acceptance test for this :-) -
core-ci voted on patch set 8 V +1 11/10/23, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48786
-
Simon Schaufelberger voted on patch set 8 V +1 CR +1 11/18/23, 15:37
-
Simon Schaufelberger commented on patch set 8 11/18/23, 15:39
the commit message is not parsed with REST, thus making the :php: prefix useless -
Garvin Hicking uploaded patch set 9
CR +1V +111/21/23, 11:41Reduced scope of change to only affect checkbox radio option elements -
Garvin Hicking uploaded patch set 10 11/21/23, 11:43
Removed two remaining usages -
core-ci voted on patch set 9 V +1 11/21/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49215
-
core-ci voted on patch set 10 V +1 11/21/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49217
-
Christian Kuhn commented on patch set 10 11/21/23, 15:01
Reply
Done -
Christian Kuhn uploaded patch set 11
V +111/21/23, 15:19 -
core-ci voted on patch set 11 V +1 11/21/23, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49248
-
core-ci voted on patch set 11 V -1 11/21/23, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49249
-
Christian Kuhn uploaded patch set 12
V -111/21/23, 18:23 -
core-ci voted on patch set 12 V +1 11/21/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49282
-
core-ci commented on patch set 12 11/21/23, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49283
-
Stefan Bürk voted on patch set 12 V +1 CR +1 11/21/23, 18:43
-
Christian Kuhn voted on patch set 12 V +2 CR +2 11/21/23, 18:43
-
Christian Kuhn merged patch set 13 11/21/23, 18:43