81646[BUGFIX] Fix rendering labels for radio and select field types
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRadioItems.php+3 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php10+48 −14
- typo3/sysext/backend/Classes/View/BackendLayoutView.php1+4 −0
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+6 −3
Review log 1524
-
Marcin Sągol uploaded patch set 1 11/02/23, 13:15
-
Marcin Sągol updated the commit message in patch set 2 11/02/23, 13:19
-
Marcin Sągol updated the commit message in patch set 3 11/02/23, 13:23
-
Garvin Hicking commented on patch set 2 11/02/23, 13:23
Good work on this, I only was able to read through it and not test it, so only two smaller comments at this point.BackendUtility.php:1282Maybe do a more strict check here with `?? null` to prevent warnings on undefined arrays?BackendUtility.php:1290Might need an array key check here, too - if older userFuncs that have not addapted to named array keys, this might throws errors then? -
Marcin Sągol updated the commit message in patch set 4 11/02/23, 13:24
-
core-ci voted on patch set 1 V -1 11/02/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48488
-
core-ci voted on patch set 2 V -1 11/02/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48490
-
Marcin Sągol uploaded patch set 5 11/02/23, 13:33
-
Marcin Sągol commented on patch set 5 11/02/23, 13:34
BackendUtility.php:1282ReplyCheck added.BackendUtility.php:1290ReplyI have change the code to operate on SelectItem object. -
core-ci voted on patch set 4 V -1 11/02/23, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48492
-
Marcin Sągol rebased onto patch set 6 11/02/23, 13:47
-
core-ci voted on patch set 5 V -1 11/02/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48494
-
core-ci voted on patch set 6 V -1 11/02/23, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48497
-
Marcin Sągol uploaded patch set 7
V -111/02/23, 14:46 -
core-ci voted on patch set 7 V -1 11/02/23, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48503
-
Marcin Sągol uploaded patch set 8
V -111/02/23, 16:19 -
core-ci voted on patch set 8 V -1 11/02/23, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48509
-
Marcin Sągol uploaded patch set 9
V -111/08/23, 13:59 -
Marcin Sągol updated the commit message in patch set 10 11/08/23, 14:03
-
core-ci voted on patch set 9 V +1 11/08/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48715
-
Garvin Hicking commented on patch set 10 11/08/23, 14:33
Thanks for the improvements/work. I couldn't yet test this "for real", but gave some thoughts, maybe those can help.BackendUtility.php:1277UnresolvedIs || required at this point? Because currently, if items='' but itemsProcFunc is set, it would actually not execute the itemsProcFunc to generate needed items. This also means that in the line below, you would need to check if $columnConfig['items'] is an array, after the itemsProcFunc execution.BackendUtility.php:1282ReplyAckBackendUtility.php:1290ReplyDoneBackendUtility.php:1346UnresolvedAdding a new function argument in the middle of a method would be a serious BC (Breaking Change). A new used field should be added to the end of the list, and get a default like `null`.BackendUtility.php:1398UnresolvedTo reduce review overhead, if possible try to avoid inserting new lines if not needed - this one could maybe removed?BackendUtility.php:1589UnresolvedThis looks like a good idea to me, but I'm not sure if that could maybe break some acceptance tests, did you maybe run the full `Build/Scripts/runTests -s acceptance` suite on this?BackendLayoutView.php:211UnresolvedJust a sidenote. $parameters is passed by run-time reference, I wonder if we should take the moment and typehint this parameter as reference already? Not 100% sure on the implications of this, though. -
core-ci voted on patch set 10 V +1 11/08/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48717
-
Christian Kuhn commented on patch set 10 12/09/23, 10:09
Hey Marcin. Thanks for the patch! Unfortunately, this one has been superseded by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82148, which is merged by now. I fear Oliver realized a bit too late there was a dupe of the issue and created an own patch. We try to avoid such situations, but this time, I fear all I can do is abandon this one now. -
Christian Kuhn abandoned the change 12/09/23, 10:10