Review 12.4 Merged

81660[TASK] Respect the AsCommand `hidden` constructor argument

Benjamin Franzke CR +2 V +2 Normal +192 −10 updated 11/07/23, 06:13

Commit message

Symfony's AsCommand attribute encodes `hidden = true` into
a trailing `|` for the name attribute. Drop that for our
command list and mark the command as hidden in the command
registry.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 9

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/06/23, 19:05

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/06/23, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48670

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/07/23, 06:13

  4. Benjamin Franzke merged patch set 2 11/07/23, 06:13