81660[TASK] Respect the AsCommand `hidden` constructor argument
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Configuration/Services.php+3 −3
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-101567-UseSymfonyAttributeToAutoconfigureCliCommands.rst+6 −7
- typo3/sysext/core/Tests/Functional/DependencyInjection/AsCommandAttributeTest.phpnew+70 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/Command/HiddenTestCommand.phpnew+32 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/Command/VisibleTestCommand.phpnew+32 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Configuration/Services.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/composer.jsonnew+19 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/ext_emconf.phpnew+21 −0
- composer.json+1 −0
Review log 34
-
Benjamin Franzke commented on patch set 1 11/06/23, 19:05
Cherry Picked from branch main. -
core-ci voted on patch set 1 V +1 11/06/23, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48670
-
Benjamin Franzke voted on patch set 1 V +2 CR +2 11/07/23, 06:13
-
Benjamin Franzke merged patch set 2 11/07/23, 06:13