Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
81680[WIP][TASK] Cleanup ConsumerScope
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/80/81680/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/80/81680/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
81680 [WIP][TASK] Cleanup ConsumerScope This change
-
main
81644[TASK] Remove usages of $.Deferred()
The chain has patch set 3 of 5, the changes above it need a rebase.
Files 14
- Build/Sources/TypeScript/backend/event/consumer-scope.ts+1 −3
- Build/Sources/TypeScript/backend/event/interaction-request-assignment.tsdeleted+0 −24
- Build/Sources/TypeScript/backend/event/interaction-request-map.tsdeleted+0 −75
- Build/Sources/TypeScript/backend/viewport/abstract-container.ts+3 −3
- Build/Sources/TypeScript/backend/viewport/navigation-container.ts+0 −5
- Build/Sources/TypeScript/backend/form-engine.ts+30 −40
- Build/Sources/TypeScript/backend/viewport.ts+5 −4
- typo3/sysext/backend/Resources/Public/JavaScript/event/consumer-scope.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/event/interaction-request-assignment.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/event/interaction-request-map.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/abstract-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/navigation-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport.js+1 −1
Review log 34
-
Benjamin Franzke uploaded patch set 1 11/03/23, 17:23
-
core-ci voted on patch set 1 V +1 11/03/23, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48556
-
Oliver Hader commented on patch set 1 11/06/23, 18:28
back-then™ (2017) I had the idea of having that for more components than just `FormEngine`, see * https://review.typo3.org/c/Packages/TYPO3.CMS/+/53075/13/typo3/sysext/core/Documentation/Changelog/master/Feature-77268-IntroduceJavaScriptTriggerRequestAPI.rst * https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/9.0/Feature-77268-IntroduceJavaScriptTriggerRequestAPI.html#registering-component -
Benjamin Franzke marked it work in progress 05/30/24, 07:16