Review 12.4 Merged

81683[TASK] Migrate icon-element to @lit/task

Benjamin Franzke CR +2 V +2 Hard +350 −113 updated 11/04/23, 10:44

Commit message

@lit/task graduated from a 2-year @lit-labs phase, to an officially
supported helper library for lit elements. We want to start using it
as it embraces a tri-state model for async operations:

  * pending
  * complete
  * error

…which is important in order to always handle error cases instead of
silently ignoring them. Also existing or currently running requests are
aborted and/or ignored when a newer state has already been activated.

The icon-library deduplication caching strategy is refactored into a
reusable helper instance that is a bit more generic and allows to
abort (ref counted across duplicate requests) async operations.

Commands executed:

  npm install --save @lit/task
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 34

  1. Benjamin Franzke uploaded patch set 1 11/04/23, 10:00

  2. core-ci voted on patch set 1 V +1 11/04/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48563

  3. Benjamin Franzke commented on patch set 1 V +2 CR +2 11/04/23, 10:44

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 11/04/23, 10:44